fix: cross-origin fetch noise, bytes.Reader race, and form decoding fallback#130
Open
eideroliveira wants to merge 1 commit into
Open
fix: cross-origin fetch noise, bytes.Reader race, and form decoding fallback#130eideroliveira wants to merge 1 commit into
eideroliveira wants to merge 1 commit into
Conversation
…allback fetchInterceptor: skip cross-origin requests (e.g. Google Analytics) entirely — we have no insight into them and forcing a JSON parse on their bodies just produces console noise. Also swallow JSON parse errors on same-origin responses: a non-JSON body is not an error, only the request lifecycle matters. builder: create a new bytes.Reader per request in PacksHandler to avoid a data race when concurrent requests share the same reader (its seek offset is mutated by http.ServeContent). api: fall back to r.Form when MultipartForm is nil so that URL-encoded POST bodies are decoded correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three independent bugfixes discovered while running go-plaid in production:
fetchInterceptor: Skip cross-origin requests (e.g. Google Analytics) entirely — we have no insight into them and forcing a JSON parse on their bodies just produces console noise. Also swallow JSON parse errors on same-origin responses gracefully: a non-JSON body is not an error, only the request lifecycle matters.
builder.PacksHandler: Create a new
bytes.Readerper request to avoid a data race —http.ServeContentmutates the reader's seek offset, so concurrent requests sharing the same reader corrupt each other.api.UnmarshalForm: Fall back to
r.FormwhenMultipartFormis nil so that URL-encoded POST bodies are decoded correctly.Test plan