fix(vuetify): allow NoGutters(false) to explicitly disable gutters#579
Open
eideroliveira wants to merge 1 commit into
Open
fix(vuetify): allow NoGutters(false) to explicitly disable gutters#579eideroliveira wants to merge 1 commit into
eideroliveira wants to merge 1 commit into
Conversation
Previously NoGutters only set the attribute when v=true, making it impossible to explicitly set no-gutters="false" to override a parent default. Now the attribute is always set regardless of the boolean value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VRowBuilder.NoGutters(v)previously only set the:no-guttersattribute whenv=true, making it impossible to explicitly passno-gutters="false"to override a parent default. Now the attribute is always emitted regardless of the boolean value.Test plan
NoGutters(true)still produces:no-gutters="true"NoGutters(false)now produces:no-gutters="false"instead of being silently dropped