chore(test): migrate exchange test setup to gormx.MustStartTestSuite#583
Open
dorothyyzh wants to merge 5 commits into
Open
chore(test): migrate exchange test setup to gormx.MustStartTestSuite#583dorothyyzh wants to merge 5 commits into
dorothyyzh wants to merge 5 commits into
Conversation
Use MustStartTestSuite to manage the PostgreSQL container lifecycle. Open a plain gorm.Open connection from testSuite.DSN() instead of using testSuite.DB(), because exchange's importer relies on GORM creating nested associations for new records during CreateInBatches — incompatible with the OmitAssociationsPlugin that SetupDatabase (and thus MustStartTestSuite) installs on its managed connection. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…and CVE-2026-34040 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Provides redisx.MustStartTestSuite for integration tests, mirroring the gormx.MustStartTestSuite pattern. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…er transitive dep Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…uite)" This reverts commit 978d987.
iBakuman
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
exchange/setup_test.gofromOpenContainer+gorm.Opentogormx.MustStartTestSuitefor container lifecycle management.Uses
testSuite.DSN()to open a plaingorm.Openconnection rather thantestSuite.DB(), because exchange's importer creates nested associations for new records duringCreateInBatches— this is incompatible with theOmitAssociationsPluginthatMustStartTestSuiteinstalls on its managed connection.Verification
go test ./exchange/...— all tests pass