Open
Conversation
… configurations. Updated uses of mem::uninitialized in dxgi/mod.rs and quartz/display.rs to use mem::zeroed instead. Added a local copy of D3D_FEATURE_LEVEL_9_1 in Capturer::new in dxgi/mod.rs so that it can be passed in to D3D11CreateDevice as mutable. Added a type annotation for the IDXGIOutput1 pointer used in Displays::read_and_invalidate in dxgi/mod.rs.
Author
|
That final warning goes away with ...in |
Author
|
I guess it must be because the code doesn't compile at all with any of the other possible values. 😁 |
Author
|
Author
|
Oh wow, I was working on another project that uses Scrap and didn't realize it was using its own embedded copy of the code with many modifications and extensions, and when I came here to the source repo, I didn't notice that this project hasn't been updated in 6 years. 😛 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains (hopefully) trivial changes to eliminate build warnings.
Before:
After:
Please be gentle and check that I haven't made any mistakes. I have experience with lots of languages but Rust isn't one of them. 😛