chore: port TSQL CREATE EXTERNAL TABLE (#4642)#2675
Open
mikills wants to merge 2 commits into
Open
Conversation
## Summary - SQLFluff #4642 added the T-SQL `CREATE EXTERNAL TABLE` statement. Ported it to sqruff's `tsql.rs`: new `CreateExternalTableStatementSegment` (column list + `WITH (...)` options — reusing `TableLocationClause`, plus `DATA_SOURCE`/`FILE_FORMAT`/`REJECT_TYPE`/`REJECT_VALUE`/`REJECT_SAMPLE_VALUE`/`REJECTED_ROW_LOCATION`), wired into the T-SQL statement list, with the option keywords registered as unreserved. - Added the `create_external_table` fixture (.sql + .yml); the dialect test parses it with no unparsable segments. Parser-only change. Ported from SQLFluff 1b8ba7f57886a971808ccbb2614cacb4e659535c sqlfluff/sqlfluff#4642 sqlfluff/sqlfluff@1b8ba7f
Contributor
Benchmark for 19b0e19Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CREATE EXTERNAL TABLEstatement. Ported it to sqruff'stsql.rs: newCreateExternalTableStatementSegment(column list +WITH (...)options — reusingTableLocationClause, plusDATA_SOURCE/FILE_FORMAT/REJECT_TYPE/REJECT_VALUE/REJECT_SAMPLE_VALUE/REJECTED_ROW_LOCATION), wired into the T-SQL statement list, with the option keywords registered as unreserved.create_external_tablefixture (.sql + .yml); the dialect test parses it with no unparsable segments. Parser-only change.Ported from SQLFluff 1b8ba7f57886a971808ccbb2614cacb4e659535c
sqlfluff/sqlfluff#4642
sqlfluff/sqlfluff@1b8ba7f