Skip to content

Cleaned up code and updated depedencies#38

Merged
spietras merged 1 commit intomainfrom
cleanup
Feb 28, 2026
Merged

Cleaned up code and updated depedencies#38
spietras merged 1 commit intomainfrom
cleanup

Conversation

@spietras
Copy link
Member

No description provided.

@spietras spietras requested a review from Copilot February 28, 2026 20:56
@spietras spietras self-assigned this Feb 28, 2026
@spietras spietras added the cleanup Stay fresh label Feb 28, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates generated API client code and dependency versions, and refactors the shared useForm hook types/behavior to support optional submission handling.

Changes:

  • Updated useForm hook types and submit handling (including making onSubmit optional).
  • Regenerated/adjusted icanhazdadjoke API client typings and request helpers.
  • Bumped @hey-api/openapi-ts (and related lockfile dependency updates).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/src/isomorphic/core/hooks/use-form/types.ts Refactors form hook public types (errors/output types, submit event type, optional onSubmit).
src/src/isomorphic/core/hooks/use-form/main.ts Adjusts submit handler to no-op when onSubmit is absent.
src/src/common/apis/icanhazdadjoke/schemas.ts Minor Zod schema style adjustment for optional never() fields.
src/src/common/apis/icanhazdadjoke/core/params.ts Improves empty-slot stripping to avoid treating arrays as empty objects.
src/src/common/apis/icanhazdadjoke/clnt.ts Updates generated CreateClientConfig type to allow async config.
src/src/common/apis/icanhazdadjoke/client/types.ts Updates generated request option typing and CreateClientConfig to allow async config.
src/package.json.jinja Bumps @hey-api/openapi-ts devDependency.
src/package-lock.json.jinja Lockfile updates reflecting dependency bumps and transitive changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@spietras spietras merged commit 319f650 into main Feb 28, 2026
6 checks passed
@spietras spietras deleted the cleanup branch February 28, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Stay fresh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants