Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates generated API client code and dependency versions, and refactors the shared useForm hook types/behavior to support optional submission handling.
Changes:
- Updated
useFormhook types and submit handling (including makingonSubmitoptional). - Regenerated/adjusted icanhazdadjoke API client typings and request helpers.
- Bumped
@hey-api/openapi-ts(and related lockfile dependency updates).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/src/isomorphic/core/hooks/use-form/types.ts |
Refactors form hook public types (errors/output types, submit event type, optional onSubmit). |
src/src/isomorphic/core/hooks/use-form/main.ts |
Adjusts submit handler to no-op when onSubmit is absent. |
src/src/common/apis/icanhazdadjoke/schemas.ts |
Minor Zod schema style adjustment for optional never() fields. |
src/src/common/apis/icanhazdadjoke/core/params.ts |
Improves empty-slot stripping to avoid treating arrays as empty objects. |
src/src/common/apis/icanhazdadjoke/clnt.ts |
Updates generated CreateClientConfig type to allow async config. |
src/src/common/apis/icanhazdadjoke/client/types.ts |
Updates generated request option typing and CreateClientConfig to allow async config. |
src/package.json.jinja |
Bumps @hey-api/openapi-ts devDependency. |
src/package-lock.json.jinja |
Lockfile updates reflecting dependency bumps and transitive changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.