Fix for #1670 and #1671. Disabled resolve_link_package test#1672
Open
robchallen wants to merge 6 commits intor-lib:mainfrom
Open
Fix for #1670 and #1671. Disabled resolve_link_package test#1672robchallen wants to merge 6 commits intor-lib:mainfrom
robchallen wants to merge 6 commits intor-lib:mainfrom
Conversation
Author
|
Will re-open with fixes |
Author
|
Reopen to test if working now |
Author
|
Sigh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in additional functionality: @inheritAllDotParams, which inherits transitively the documentation of
...parameters propagating upwards through the function definitions. This is useful if you extend functions that have already have documentation for...parameters. Its got potential to cause issues hence new tag. This fixes #1671 and #1670. I could not make all tests pass due to issues with cached test results. (Current error is due to reordering in test output compared to snapshot)