Make Typed Racket implementation structs authentic.#1072
Merged
Conversation
Member
|
Should we also make other structs authentic, like those in |
Member
Author
|
Yes, I think so. |
samth
force-pushed
the
authentic-structs
branch
4 times, most recently
from
a15559a to
6285ba4
Compare
samth
force-pushed
the
authentic-structs
branch
5 times, most recently
from
5450771 to
6c875d1
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 34 files in this pull request and found no issues.
There was a problem hiding this comment.
Resyntax analyzed 33 files in this pull request and found no issues.
There was a problem hiding this comment.
Resyntax analyzed 13 files in this pull request and found no issues.
Add #:authentic to internal structs across the codebase: - Type representation structs (rep/, env/) - Static contract combinators and structures - Type inference structs (infer/) - Type checking structs (typecheck/) - Parsing mode structs (private/) These structs are internal implementation details that should not be impersonated at runtime.
samth
force-pushed
the
authentic-structs
branch
from
6c875d1 to
0835831
Compare
There was a problem hiding this comment.
Resyntax analyzed 14 files in this pull request and found no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.