use the new version of object/c#1495
Merged
Merged
Conversation
samth
reviewed
Feb 13, 2026
| (object/c ?clause ... | ||
| #:opaque-except typed-method? | ||
| #:opaque-fields #t | ||
| #:do-not-check-class-field-accessor-or-mutator-access))])) |
Member
There was a problem hiding this comment.
Does this keyword mean that we're maintaining the unsoundness here? I think we should just fix it.
Member
Author
There was a problem hiding this comment.
Yes.
Fixing it is fine but shouldn't hold up these changes, in my opinion. This argument isn't there just for TR, as others may be relying on that behavior too.
Member
There was a problem hiding this comment.
Just for clarity, dropping this keyword would (we think) break existing programs until we do something smarter elsewhere.
Member
|
"+9 -167" I love it! |
rfindler
force-pushed
the
new-object-c
branch
from
186cb7b to
97302ee
Compare
Member
Author
|
Just noticed that there was an obsolete comments, so I deleted that too. It may make sense to delete the syntax class, too. |
samth
approved these changes
Feb 16, 2026
rfindler
force-pushed
the
new-object-c
branch
from
97302ee to
0adf3f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of the change in racket/racket#5428