Conversation
|
Hey @anuj-pal27 I've been thinking about the Would love your review! |
085f4f3 to
7805151
Compare
|
Hey @rsamoilov — I reviewed the new approach of routing custom renderers through render (e.g. render csv: ...) and I understand the discoverability motivation, plus it keeps the status/body/double-render logic in one place. One thing I want to double-check: if a renderer block sets headers["content-type"] (e.g. "text/html") and the implementation then delegates to render plain: result.to_s, does the plain branch still overwrite the content-type to "text/plain; charset=utf-8"? |
|
No, it doesn't - the changes you've implemented are still there. |
This pull request introduces a redesign of the custom renderer system. Instead of generating separate
render_<name>methods for each custom renderer, the system now overloads the mainrendermethod in controllers to support custom renderers via keyword arguments.ref #244