Only parse request body as multipart if the request is multipart#256
Merged
rsamoilov merged 1 commit intorage-rb:mainfrom Apr 1, 2026
Merged
Only parse request body as multipart if the request is multipart#256rsamoilov merged 1 commit intorage-rb:mainfrom
rsamoilov merged 1 commit intorage-rb:mainfrom
Conversation
If a request body is not json, urlencoded or multipart, there is no reason to raise an BadRequest error. The query and url params should still be returned in this case.
p8
changed the title
rsamoilov
pushed a commit
that referenced
this pull request
Apr 1, 2026
If a request body is not json, urlencoded or multipart, there is no reason to raise an BadRequest error. The query and url params should still be returned in this case.
Member
|
Also, let me know if there's anything I can do to help with the HttpArena benchmark. I'll try to look into it at some point too. |
Contributor
Author
|
Thanks @rsamoilov . I'll let you know when I run into issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a request body is not json, urlencoded or multipart, there is no reason to raise an BadRequest error.
The query and url params should still be returned in this case.
This fixes an issue in the HttpArena benchmark (the successor to TechEmpower), where a plain text body should be read for one of the tests. A plain request body should be added to a sum.
Currently this is handled with a MonkeyPatch:
https://github.com/MDA2AV/HttpArena/blob/main/frameworks/rage/config/application.rb#L28-L35