feat(deferred): Improve default retry strategy#257
Open
xingzihai wants to merge 1 commit intorage-rb:mainfrom
Open
feat(deferred): Improve default retry strategy#257xingzihai wants to merge 1 commit intorage-rb:mainfrom
xingzihai wants to merge 1 commit intorage-rb:mainfrom
Conversation
- Change MAX_ATTEMPTS from 5 to 15 for ~2 days total retry time - Change backoff formula from exponential to polynomial: (attempt+1)**4 + 10 + rand(15) * (attempt+1) - Remove BACKOFF_INTERVAL constant (no longer needed) - Update tests to match new backoff behavior This gives developers more time to discover and fix underlying issues before retry attempts are exhausted. Closes rage-rb#251
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the default retry strategy for
Rage::Deferredtasks as described in #251.Changes
Increased MAX_ATTEMPTS from 5 to 15
Changed backoff formula from exponential to polynomial
rand(5 * 2**attempt) + 1(exponential growth)(attempt**4) + 10 + (rand(15) * attempt)(polynomial growth)Retry timing comparison
Total retry time
Testing
Updated spec tests to verify the new backoff intervals:
__next_retry_in(0, nil)returns between 11-25 seconds__next_retry_in(1, nil)returns between 26-54 seconds__next_retry_in(15, nil)returns between 50635-50845 seconds (~14h)__next_retry_in(16, nil)returns nil (max exceeded)Closes #251