Skip to content

[WUD-2880] Allow multiple future waiting and unwrapping#210

Merged
mhidalgo-rai merged 9 commits into
mainfrom
mhidalgo-rai/wait-for-many-futures
May 29, 2026
Merged

[WUD-2880] Allow multiple future waiting and unwrapping#210
mhidalgo-rai merged 9 commits into
mainfrom
mhidalgo-rai/wait-for-many-futures

Conversation

@mhidalgo-rai
Copy link
Copy Markdown
Collaborator

Proposed changes

This patch updates wait_for_future() and unwrap_future() to accept multiple futures at a time, modeled after concurrent.futures.wait() and concurrent.futures.as_completed().

Checklist

  • Lint and unit tests pass locally
  • I have added tests that prove my changes are effective
  • I have added necessary documentation to communicate the changes

Additional comments

Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Copy link
Copy Markdown
Contributor

@jbarry-bdai jbarry-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly not 100% sure about all the code but this looks about right!

Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
Signed-off-by: Michel Hidalgo <mhidalgo@theaiinstitute.com>
@mhidalgo-rai
Copy link
Copy Markdown
Collaborator Author

mhidalgo-rai commented May 29, 2026

Making logging tests as flaky so we can unblock this. It honestly looks like delayed pub/sub discovery or message drop triggered by middleware state left behind from one test to the next. It's gotten worse recently. Fallout from the latest Humble sync perhaps.

@mhidalgo-rai mhidalgo-rai merged commit 1186d4c into main May 29, 2026
5 checks passed
@mhidalgo-rai mhidalgo-rai deleted the mhidalgo-rai/wait-for-many-futures branch May 29, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants