Skip to content

fix(pitr): also match InvalidAccessKeyId when bucket credentials are revoked #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulocsanz merged 1 commit into from
May 14, 2026
Merged

fix(pitr): also match InvalidAccessKeyId when bucket credentials are revoked #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions pgbackrest-archive-push-wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,14 @@ if [ "$PGB_RC" -eq 0 ]; then
exit 0
fi

# Bucket deleted: NoSuchBucket is the S3 error for a bucket that no longer
# exists. No retry will ever succeed without operator action, so drop the
# segment immediately rather than accumulating WAL up to the threshold.
if printf '%s\n' "$pgb_out" | grep -q 'NoSuchBucket'; then
echo "pgbackrest-wrapper: bucket does not exist (NoSuchBucket); dropping ${WAL_FILE} immediately" >&2
# Bucket deleted: when the bucket no longer exists Tigris returns NoSuchBucket
# on read paths, but validates credentials before checking bucket existence on
# write paths (archive-push is a PUT). Railway revokes the bucket credentials
# when the bucket is deleted, so in practice pgBackRest sees InvalidAccessKeyId
# on the PUT. Both errors mean no recovery without operator action — drop
# immediately rather than accumulating WAL up to the threshold.
if printf '%s\n' "$pgb_out" | grep -qE 'NoSuchBucket|InvalidAccessKeyId'; then
echo "pgbackrest-wrapper: bucket gone or credentials revoked; dropping ${WAL_FILE} immediately" >&2
touch "$PGDATA/.pgbackrest_gap_pending" 2>/dev/null || true
exit 0
fi
Expand Down
Loading