Updated to use ESP Async WebServer v3+ API#596
Open
dkozel wants to merge 2 commits intoramapcsx2:masterfrom
Open
Updated to use ESP Async WebServer v3+ API#596dkozel wants to merge 2 commits intoramapcsx2:masterfrom
dkozel wants to merge 2 commits intoramapcsx2:masterfrom
Conversation
The returned parameter values are const and need to be indexed using size_t not the implicit int type.
Open
Author
|
Realized that the platformio.ini file needed to be updated with the newer dependencies. I also added the esp12a board as I'm using a NodeMCU v3. |
|
I tested this myself and wifi settings isn't being saved, which is a known issue with ESP8266 board package 3.0+ |
|
I found a fix to the issue with WiFi settings and ESP8266 board package 3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The returned parameter values are const and need to be indexed using size_t not the implicit int type.
This might be reverse compatible with the v2 API, but I haven't tested that. I also haven't done testing of every API endpoint, but all of the logical flows look unaffected by making the returned parameter
const.I see the large PR #551 which removes ESP Async WebServer, but hope this small change will be useful to allow users to compile with the up-to-date library. There's also a documentation update for the wiki which should be done as the two ESP Async libaries have moved repos, I'll open a PR and link it to this one.
This was tested with Arduino 2.3.4, ESP8266 board package 3.1.2, ESP Async TCP 0b6de755, and ESP Async WebServer v3.6.2.
ESP Async TCP is frozen and will not be further developed according to the maintainer as the ESP8266 is considered mature.