Use current proposed-work payment state#843
Conversation
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
alan747271363-art
left a comment
There was a problem hiding this comment.
Current-head review for #654.
I reviewed PR #843 at head d40f493db5e90b17fe86f0d933f4dbb8ac34b4d0 against origin/main c504500cbe0b8c0acae692b27521ed778339d16e.
Scope reviewed:
- Inspected
scripts/proposed_work_triage.py,tests/test_proposed_work_triage.py, anddocs/admin-runbook.md. - Verified the default proposed-work triage payment state now aggregates both accepted-proposed-work bounty rounds #649 and #722, while explicit
--payment-bounty-issueoverrides still work for future round transitions. - Verified
_gh_issue_search()keeps only list-shaped rows before issue detail loading, which keeps malformed gh output from reaching the normalization path. - Confirmed the live default smoke reports #802 as pending via proposal 129 without passing
--payment-bounty-issue 722; this matches the source issue #802 problem statement.
Validation run locally:
.\.venv\Scripts\python.exe -m pytest tests/test_proposed_work_triage.py -q-> 19 passed.\.venv\Scripts\ruff.exe check scripts/proposed_work_triage.py tests/test_proposed_work_triage.py-> All checks passed.\.venv\Scripts\ruff.exe format --check scripts/proposed_work_triage.py tests/test_proposed_work_triage.py-> 2 files already formatted.\.venv\Scripts\mypy.exe scripts/proposed_work_triage.py-> Success.\.venv\Scripts\python.exe scripts/docs_smoke.py-> docs smoke okgit diff --check origin/main...HEAD-> cleangit merge-tree --write-tree origin/main HEAD-> clean treebf34a6ce76cb069c0ddc1ad19b2790bc9689eb04
Hosted state checked before review: GitHub reports CLEAN, Quality/readiness/docs/image is successful, and CodeRabbit status is successful. I did not find a blocker in the current head.
No private data, wallet material, payout execution, treasury mutation, GitHub issue mutation from the reviewed code path, exchange, bridge, cash-out, price behavior, or fabricated payout claim was used.
tolga-tom-nook
left a comment
There was a problem hiding this comment.
Reviewed current head d40f493db5e90b17fe86f0d933f4dbb8ac34b4d0 as a non-author for Bounty #654.
Evidence checked:
- Inspected
scripts/proposed_work_triage.py,tests/test_proposed_work_triage.py, anddocs/admin-runbook.md. - Confirmed the default proposed-work payment-state scan now includes both accepted-proposed-work rounds #649 and #722, and the runbook describes that default while still documenting explicit
--payment-bounty-issueoverrides for future transitions. - Confirmed
_gh_issue_search()now defends against non-listgh issue listJSON and filters/casts dict rows before returning, so later code does not silently consume an unexpected shape. - Checked duplicate/queue context: this is a focused proposed-work triage payment-state/defaults change, not the superseded admin webhook-event scope, and the PR had one useful current-head human approval before this review.
Validation run locally on this head:
uv run --extra dev pytest tests/test_proposed_work_triage.py -q-> 19 passeduv run --extra dev python scripts/docs_smoke.py-> docs smoke okuv run --extra dev ruff check scripts/proposed_work_triage.py tests/test_proposed_work_triage.py docs/admin-runbook.md-> passeduv run --extra dev ruff format --check scripts/proposed_work_triage.py tests/test_proposed_work_triage.py-> 2 files already formatteduv run --extra dev mypy scripts/proposed_work_triage.py-> successgit diff --check origin/main...HEAD-> clean
No blockers found.
aglichandrap
left a comment
There was a problem hiding this comment.
Review evidence (head SHA: d40f493db5e9):
- ✅ Scope: Updates
proposed_work_triage.pydefault payment bounty set from(649,)to(649, 722). - ✅ Docs:
admin-runbook.mdupdated to reflect new default, clarifies when--payment-bounty-issueoverride is needed. - ✅ Type safety: Adds
from typing import castimport. - ✅ Tests:
test_proposed_work_triage.pyupdated for new default behavior. - ✅ Files: 3 files, +24/-11 — focused.
- ✅ Mergeable: state=clean.
No blockers. Approve.
xiefuzheng713-alt
left a comment
There was a problem hiding this comment.
Reviewed current head as non-author. /claim #799
Bounty #799
Source issue: #802
What changed
--payment-bounty-issueoverrides available for future transitions._gh_issue_search()to return only list-shaped issue rows, which keeps the script clean under mypy.Why
The live proposed-work triage report was still loading payment state from #649 by default, so accepted/pending #722 proposals such as source issue #802 were shown as
noneunless operators manually passed--payment-bounty-issue 722.Validation
uv run --extra dev python -m pytest tests/test_proposed_work_triage.py -quv run --extra dev ruff format --check scripts/proposed_work_triage.py tests/test_proposed_work_triage.pyuv run --extra dev ruff check scripts/proposed_work_triage.py tests/test_proposed_work_triage.pyuv run --extra dev mypy scripts/proposed_work_triage.pyuv run --extra dev python scripts/docs_smoke.pypendingfrom proposal 129 without passing--payment-bounty-issue 722.