Skip to content

Use current proposed-work payment state#843

Open
manav8498 wants to merge 1 commit into
ramimbo:mainfrom
manav8498:codex/mergework-799-802-current-payment-state
Open

Use current proposed-work payment state#843
manav8498 wants to merge 1 commit into
ramimbo:mainfrom
manav8498:codex/mergework-799-802-current-payment-state

Conversation

@manav8498
Copy link
Copy Markdown

@manav8498 manav8498 commented Jun 3, 2026

Bounty #799
Source issue: #802

What changed

Why

The live proposed-work triage report was still loading payment state from #649 by default, so accepted/pending #722 proposals such as source issue #802 were shown as none unless operators manually passed --payment-bounty-issue 722.

Validation

  • uv run --extra dev python -m pytest tests/test_proposed_work_triage.py -q
  • uv run --extra dev ruff format --check scripts/proposed_work_triage.py tests/test_proposed_work_triage.py
  • uv run --extra dev ruff check scripts/proposed_work_triage.py tests/test_proposed_work_triage.py
  • uv run --extra dev mypy scripts/proposed_work_triage.py
  • uv run --extra dev python scripts/docs_smoke.py
  • Live read-only smoke: default triage output now reports Proposed work: make proposed-work triage use current intake payment state #802 as pending from proposal 129 without passing --payment-bounty-issue 722.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Mergework Public Artifact Hygiene ✅ Passed No investment, price, cash-out/off-ramp, fabricated payout, or security claims found. MRWK appropriately described as native coin supporting future snapshots/bridges/onchain.
Bounty Pr Focus ✅ Passed PR changes match stated focus: added bounty issues #649 and #722 to default payment-state lookup, updated documentation, defensive typing fixes, and comprehensive test coverage for both issues.
Title check ✅ Passed The title 'Use current proposed-work payment state' directly describes the main change: updating payment-state lookup to include both rounds #649 and #722 by default.
Description check ✅ Passed The PR description addresses all key template sections with clear evidence of validation, though it omits the explicit template structure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@alan747271363-art alan747271363-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head review for #654.

I reviewed PR #843 at head d40f493db5e90b17fe86f0d933f4dbb8ac34b4d0 against origin/main c504500cbe0b8c0acae692b27521ed778339d16e.

Scope reviewed:

  • Inspected scripts/proposed_work_triage.py, tests/test_proposed_work_triage.py, and docs/admin-runbook.md.
  • Verified the default proposed-work triage payment state now aggregates both accepted-proposed-work bounty rounds #649 and #722, while explicit --payment-bounty-issue overrides still work for future round transitions.
  • Verified _gh_issue_search() keeps only list-shaped rows before issue detail loading, which keeps malformed gh output from reaching the normalization path.
  • Confirmed the live default smoke reports #802 as pending via proposal 129 without passing --payment-bounty-issue 722; this matches the source issue #802 problem statement.

Validation run locally:

  • .\.venv\Scripts\python.exe -m pytest tests/test_proposed_work_triage.py -q -> 19 passed
  • .\.venv\Scripts\ruff.exe check scripts/proposed_work_triage.py tests/test_proposed_work_triage.py -> All checks passed
  • .\.venv\Scripts\ruff.exe format --check scripts/proposed_work_triage.py tests/test_proposed_work_triage.py -> 2 files already formatted
  • .\.venv\Scripts\mypy.exe scripts/proposed_work_triage.py -> Success
  • .\.venv\Scripts\python.exe scripts/docs_smoke.py -> docs smoke ok
  • git diff --check origin/main...HEAD -> clean
  • git merge-tree --write-tree origin/main HEAD -> clean tree bf34a6ce76cb069c0ddc1ad19b2790bc9689eb04

Hosted state checked before review: GitHub reports CLEAN, Quality/readiness/docs/image is successful, and CodeRabbit status is successful. I did not find a blocker in the current head.

No private data, wallet material, payout execution, treasury mutation, GitHub issue mutation from the reviewed code path, exchange, bridge, cash-out, price behavior, or fabricated payout claim was used.

@manav8498 manav8498 marked this pull request as ready for review June 3, 2026 15:20
@ramimbo ramimbo changed the title [codex] Use current proposed-work payment state Use current proposed-work payment state Jun 3, 2026
@ramimbo
Copy link
Copy Markdown
Owner

ramimbo commented Jun 3, 2026

Maintainer queue status: title hygiene fixed. Held before merge/payment: current head is clean, but it needs two useful current-head human reviews and review of the #799/#802 scope before acceptance.

Copy link
Copy Markdown
Contributor

@tolga-tom-nook tolga-tom-nook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head d40f493db5e90b17fe86f0d933f4dbb8ac34b4d0 as a non-author for Bounty #654.

Evidence checked:

  • Inspected scripts/proposed_work_triage.py, tests/test_proposed_work_triage.py, and docs/admin-runbook.md.
  • Confirmed the default proposed-work payment-state scan now includes both accepted-proposed-work rounds #649 and #722, and the runbook describes that default while still documenting explicit --payment-bounty-issue overrides for future transitions.
  • Confirmed _gh_issue_search() now defends against non-list gh issue list JSON and filters/casts dict rows before returning, so later code does not silently consume an unexpected shape.
  • Checked duplicate/queue context: this is a focused proposed-work triage payment-state/defaults change, not the superseded admin webhook-event scope, and the PR had one useful current-head human approval before this review.

Validation run locally on this head:

  • uv run --extra dev pytest tests/test_proposed_work_triage.py -q -> 19 passed
  • uv run --extra dev python scripts/docs_smoke.py -> docs smoke ok
  • uv run --extra dev ruff check scripts/proposed_work_triage.py tests/test_proposed_work_triage.py docs/admin-runbook.md -> passed
  • uv run --extra dev ruff format --check scripts/proposed_work_triage.py tests/test_proposed_work_triage.py -> 2 files already formatted
  • uv run --extra dev mypy scripts/proposed_work_triage.py -> success
  • git diff --check origin/main...HEAD -> clean

No blockers found.

Copy link
Copy Markdown
Contributor

@aglichandrap aglichandrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review evidence (head SHA: d40f493db5e9):

  • Scope: Updates proposed_work_triage.py default payment bounty set from (649,) to (649, 722).
  • Docs: admin-runbook.md updated to reflect new default, clarifies when --payment-bounty-issue override is needed.
  • Type safety: Adds from typing import cast import.
  • Tests: test_proposed_work_triage.py updated for new default behavior.
  • Files: 3 files, +24/-11 — focused.
  • Mergeable: state=clean.

No blockers. Approve.

Copy link
Copy Markdown

@xiefuzheng713-alt xiefuzheng713-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head as non-author. /claim #799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants