Add source filter reset link on bounties page#894
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a backend-generated ChangesClear source filter
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f3ddad72-8f03-41a9-a032-4510e09af0bd
📒 Files selected for processing (4)
app/public_routes.pyapp/templates/bounties.htmltests/test_bounty_pages.pytests/test_public_routes.py
9772d59 to
573d594
Compare
mauricemohr88-debug
left a comment
There was a problem hiding this comment.
Current-head review for #838 on 573d594dad8675664ae84913dca020ae5d4d3abd.
Evidence checked:
- Inspected
app/public_routes.py;clear_source_filter_urlclears onlyrepoandissue_numberwhile preserving status, query, sort, limit, and availability through the existing_bounties_page_urlhelper. - Inspected
app/templates/bounties.html; the source-filter notice now renders a clear-source link only when a source filter is active. - Inspected
tests/test_bounty_pages.pyandtests/test_public_routes.py; coverage includes the simple source-filter page link and preservation of other filters includinglimitandavailability. - Confirmed GitHub reports PR #894 open, current head
573d594dad8675664ae84913dca020ae5d4d3abd, merge state clean, and both visible checks successful. - Ran
uv run --python 3.12 --extra dev python -m pytest tests/test_bounty_pages.py tests/test_public_routes.py -q: 25 passed, 1 existing Starlette warning. - Ran
uv run --python 3.12 --extra dev ruff check app/public_routes.py tests/test_public_routes.py tests/test_bounty_pages.py: passed. - Ran
uv run --python 3.12 --extra dev ruff format --check app/public_routes.py tests/test_public_routes.py tests/test_bounty_pages.py: 3 files already formatted. - Ran
uv run --python 3.12 --extra dev mypy app/public_routes.py: success. - Ran
uv run --python 3.12 --extra dev python scripts/docs_smoke.py: docs smoke ok. - Ran
git diff --check origin/main...HEADandgit merge-tree --write-tree origin/main HEAD: clean.
No blocker found. The change is narrow contributor navigation, preserves existing filters correctly, and does not touch ledger, wallet, treasury, or payout behavior.
Refs #845
What changed
clear_source_filter_urlto the public bounties page context.Clear source filterlink when the list is filtered by source repo and/or issue number.limitandavailabilityafter CodeRabbit review feedback.Why
Source-filtered bounty list links are useful for routing contributors from a GitHub issue to matching public bounty rows, but the page previously only described the active source filter. This gives contributors a direct way back to the broader filtered bounty list without manually editing the URL.
Validation
uv run --python 3.12 --extra dev python -m pytest tests/test_bounty_pages.py tests/test_public_routes.py -q-> 25 passed, 1 existing Starlette/httpx warninguv run --python 3.12 --extra dev ruff check app/public_routes.py tests/test_public_routes.py tests/test_bounty_pages.py-> passeduv run --python 3.12 --extra dev ruff format --check app/public_routes.py tests/test_public_routes.py tests/test_bounty_pages.py-> 3 files already formatteduv run --python 3.12 --extra dev mypy app/public_routes.py-> successuv run --python 3.12 --extra dev python scripts/docs_smoke.py-> docs smoke okgit diff --check origin/main...HEAD-> cleangit merge-tree --write-tree origin/main HEAD-> clean tree38fcf622f7e1a428f17a13830dda90e828042614Scope: public bounty list contributor navigation only. No ledger, wallet, treasury, payout, proposal execution, admin-token behavior, private data, exchange, bridge, cash-out, or MRWK price behavior changed.
Summary by CodeRabbit