Clarify bounty contributor routing#896
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe bounty detail page is updated to clarify claimability prerequisites and PR reference guidance. A new "Claimability checklist" section is added to the template with supporting CSS styling, the "Before you start" guidance is refined to specify GitHub issue state and reservation comment checks, and test coverage is added and updated to verify these changes. ChangesBounty detail claimability guidance
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
xiefuzheng713-alt
left a comment
There was a problem hiding this comment.
Approved current head a01b0b7ccc1b2670a5b724738540d202b8ca8db8.
Evidence checked:
- inspected
app/templates/bounty_detail.htmland confirmed the new guidance keeps contributor routing on existing public signals: live GitHub issue,mrwk:bounty,Reserved on MergeWork, effective award capacity, visible capacity, and reference formats; - inspected
tests/test_bounty_pages.pyand confirmed the new detail-page coverage asserts the claimability checklist, effective/visible capacity values, andCloses #...guidance; - inspected
app/static/style.cssand confirmed the new checklist styling is scoped to.claimability-checklistand does not affect ledger/wallet/admin layouts; - checked hosted Quality/readiness/docs/image and CodeRabbit are both successful, and the PR is mergeStateStatus CLEAN.
Validation run locally on the current head:
uv run --python 3.12 --extra dev python -m pytest tests/test_bounty_pages.py -q-> 19 passed, 1 existing Starlette/httpx warninguv run --python 3.12 --extra dev ruff check tests/test_bounty_pages.py-> passeduv run --python 3.12 --extra dev ruff format --check tests/test_bounty_pages.py-> 1 file already formatteduv run --python 3.12 --extra dev python scripts/docs_smoke.py-> docs smoke okgit diff --check origin/main...HEAD-> cleangit merge-tree --write-tree origin/main HEAD-> clean tree5a346574ef479acd69a0bee7e38a5aa1df09b3ea- overlap check: merge-tree with PR #884 was clean (
ba7809938503e149033d345c7ec13b9daaed8107), while merge-tree with PR #890 currently conflicts intests/test_bounty_pages.py; if #890 lands first, this PR will need a small test rebase/resolve.
Verdict: no blocker against current main; the #890 overlap is worth tracking but does not change the current-head approval. No private data, credentials, wallet material, ledger mutation, treasury mutation, payout/proof execution, exchange, bridge, cash-out, MRWK price behavior, or fabricated payout claims used.
Summary
Bounty #...orRefs #..., and reserveCloses #...for cases where maintainers want the bounty issue closedBounty #845
Validation
UV_CACHE_DIR=.uv-cache uv run pytest tests/test_bounty_pages.py -q-> 19 passedUV_CACHE_DIR=.uv-cache uv run ruff check tests/test_bounty_pages.py-> passedUV_CACHE_DIR=.uv-cache uv run ruff format --check tests/test_bounty_pages.py-> passedgit diff --check-> passedScope notes
Summary by CodeRabbit
New Features
Improvements