Skip to content

Clarify bounty contributor routing#896

Closed
sayuru-akash wants to merge 1 commit into
ramimbo:mainfrom
sayuru-akash:codex/845-contributor-routing-clarity
Closed

Clarify bounty contributor routing#896
sayuru-akash wants to merge 1 commit into
ramimbo:mainfrom
sayuru-akash:codex/845-contributor-routing-clarity

Conversation

@sayuru-akash
Copy link
Copy Markdown

@sayuru-akash sayuru-akash commented Jun 4, 2026

Summary

  • clarify the bounty detail next-steps copy so contributors verify the live GitHub issue signals before starting
  • make the PR reference guidance explicit: use Bounty #... or Refs #..., and reserve Closes #... for cases where maintainers want the bounty issue closed
  • add a claimability checklist for public status, effective award capacity after pending proposals, and visible capacity before pending proposals

Bounty #845

Validation

  • UV_CACHE_DIR=.uv-cache uv run pytest tests/test_bounty_pages.py -q -> 19 passed
  • UV_CACHE_DIR=.uv-cache uv run ruff check tests/test_bounty_pages.py -> passed
  • UV_CACHE_DIR=.uv-cache uv run ruff format --check tests/test_bounty_pages.py -> passed
  • git diff --check -> passed

Scope notes

  • no bounty creation, payout, ledger, wallet, admin-token, or API mutation changes
  • only touches the public bounty detail page copy, small supporting CSS, and focused page tests

Summary by CodeRabbit

  • New Features

    • Added a "Claimability checklist" section on bounty detail pages displaying relevant capacity and status information
    • Updated "Before you start" guidance with checks for GitHub issue state and reservation details
  • Improvements

    • Enhanced clarity on award capacity visibility and PR reference formatting

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b47e768e-4152-40bf-8bf2-d12b7ba3806f

📥 Commits

Reviewing files that changed from the base of the PR and between d4d0e48 and a01b0b7.

📒 Files selected for processing (3)
  • app/static/style.css
  • app/templates/bounty_detail.html
  • tests/test_bounty_pages.py

📝 Walkthrough

Walkthrough

The bounty detail page is updated to clarify claimability prerequisites and PR reference guidance. A new "Claimability checklist" section is added to the template with supporting CSS styling, the "Before you start" guidance is refined to specify GitHub issue state and reservation comment checks, and test coverage is added and updated to verify these changes.

Changes

Bounty detail claimability guidance

Layer / File(s) Summary
Claimability checklist CSS styling
app/static/style.css
New .claimability-checklist class with top border, spacing, and indented list styling.
Bounty detail template and guidance
app/templates/bounty_detail.html
"Before you start" checklist refined to check GitHub issue state and mrwk:bounty/reservation comment; new "Claimability checklist" section added to clarify bounty status, award capacity, and Closes #... usage.
Claimability and PR reference test coverage
tests/test_bounty_pages.py
New test verifies claimability and PR reference guidance; existing test updated to match revised wording for GitHub issue confirmation, reservation labels, and bounty/refs header text.

Possibly related PRs

  • ramimbo/mergework#444: Updates app/templates/bounty_detail.html and tests/test_bounty_pages.py to expand the same "Before you start"/contributor guidance on the bounty detail page.
  • ramimbo/mergework#686: Updates bounty detail page claimability guidance and tests to reflect the same live-claimability signals (mrwk:bounty, "Reserved on MergeWork", capacity conditions) enforced in the GitHub bounty issue template.
  • ramimbo/mergework#836: Modifies app/templates/bounty_detail.html and updates shared assertions in tests/test_bounty_pages.py around new UI text on the bounty detail page.
🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Clarify bounty contributor routing' is concrete and clearly names the main changed surface: bounty detail page messaging and flow for contributors.
Description check ✅ Passed The PR description includes all required sections: Summary (3 bullet points), Evidence (with Bounty #845), Validation (test and lint checks), and Scope notes. All critical information is present and specific.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Mergework Public Artifact Hygiene ✅ Passed No investment, price, cash-out, fabricated payout, or security claims found. Payment explicitly non-guaranteed and conditional on award availability.
Bounty Pr Focus ✅ Passed Three files modified match stated scope; changes align with PR objectives; no out-of-scope modifications; line counts and test assertions verified against template content.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@xiefuzheng713-alt xiefuzheng713-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved current head a01b0b7ccc1b2670a5b724738540d202b8ca8db8.

Evidence checked:

  • inspected app/templates/bounty_detail.html and confirmed the new guidance keeps contributor routing on existing public signals: live GitHub issue, mrwk:bounty, Reserved on MergeWork, effective award capacity, visible capacity, and reference formats;
  • inspected tests/test_bounty_pages.py and confirmed the new detail-page coverage asserts the claimability checklist, effective/visible capacity values, and Closes #... guidance;
  • inspected app/static/style.css and confirmed the new checklist styling is scoped to .claimability-checklist and does not affect ledger/wallet/admin layouts;
  • checked hosted Quality/readiness/docs/image and CodeRabbit are both successful, and the PR is mergeStateStatus CLEAN.

Validation run locally on the current head:

  • uv run --python 3.12 --extra dev python -m pytest tests/test_bounty_pages.py -q -> 19 passed, 1 existing Starlette/httpx warning
  • uv run --python 3.12 --extra dev ruff check tests/test_bounty_pages.py -> passed
  • uv run --python 3.12 --extra dev ruff format --check tests/test_bounty_pages.py -> 1 file already formatted
  • uv run --python 3.12 --extra dev python scripts/docs_smoke.py -> docs smoke ok
  • git diff --check origin/main...HEAD -> clean
  • git merge-tree --write-tree origin/main HEAD -> clean tree 5a346574ef479acd69a0bee7e38a5aa1df09b3ea
  • overlap check: merge-tree with PR #884 was clean (ba7809938503e149033d345c7ec13b9daaed8107), while merge-tree with PR #890 currently conflicts in tests/test_bounty_pages.py; if #890 lands first, this PR will need a small test rebase/resolve.

Verdict: no blocker against current main; the #890 overlap is worth tracking but does not change the current-head approval. No private data, credentials, wallet material, ledger mutation, treasury mutation, payout/proof execution, exchange, bridge, cash-out, MRWK price behavior, or fabricated payout claims used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants