Accept bounty_id alias for MCP get_bounty#908
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe PR extends the ChangesBounty ID Alias Support
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
catcherintheroad-hub
left a comment
There was a problem hiding this comment.
Reviewed current head 914449c31a6bb4ee0b70de8d783854b4440bbe76 for the focused MCP get_bounty selector alias change.
What I checked:
app/mcp_tools.pyextends the existingselected_bounty()helper soget_bountyacceptsbounty_idas an alias for the internalidselector.- Mixed
id+bounty_idis rejected before lookup, which avoids ambiguous internal selector input. - Existing
issue_number+ optionalrepobehavior remains on the same helper path. app/mcp.py,docs/api-examples.md, anddocs/agent-guide.mdnow document the alias in the agent-facing surface.tests/test_api_mcp.pycovers successfulbounty_idlookup, mixed internal-id rejection, and tools/list wording.
Local validation on this exact head:
uv run --python 3.12 --extra dev python -m pytest tests/test_api_mcp.py -k 'get_bounty or tools_list or bounty_id_alias' -q-> 19 passed, 88 deselected, 1 existing Starlette/httpx warning.uv run --python 3.12 --extra dev python -m pytest tests/test_api_mcp.py tests/test_mcp_tools.py -q-> 114 passed, 1 existing Starlette/httpx warning.uv run --python 3.12 --extra dev ruff check app/mcp.py app/mcp_tools.py tests/test_api_mcp.py-> passed.uv run --python 3.12 --extra dev ruff format --check app/mcp.py app/mcp_tools.py tests/test_api_mcp.py-> passed.uv run --python 3.12 --extra dev mypy app/mcp.py app/mcp_tools.py-> passed.uv run --python 3.12 --extra dev python scripts/docs_smoke.py-> passed.git diff --check origin/main...HEADandgit merge-tree --write-tree origin/main HEAD-> clean.
GitHub state checked before review: PR open and mergeable, no human reviews, no visible #838 claim for PR #908. CodeRabbit was still pending at review time, so maintainers should still consider any later bot feedback before merging. No blocker found in the reviewed code.
Summary
Bounty #844
get_bountyacceptbounty_idas an alias for the existing internalidselector;idandbounty_idso agents do not get ambiguous selector behavior;tools/listwording plus agent/API docs to mention the alias.Evidence / duplicate check
bounty_idfields from related bounty/attempt payloads.get_bounty bounty_id,bounty_id alias, andget_bounty idfound no same-scope open PR.list_bountiesargument guard, and Align submit_work_proof MCP contract #856submit_work_proofcontract alignment.Validation
.\.venv\Scripts\python.exe -m pytest tests\test_api_mcp.py tests\test_mcp_tools.py tests\test_docs_public_urls.py -q-> 149 passed, 1 existing Starlette/httpx warning.\.venv\Scripts\python.exe -m ruff check app\mcp.py app\mcp_tools.py tests\test_api_mcp.py docs\api-examples.md docs\agent-guide.md tests\test_docs_public_urls.py-> passed.\.venv\Scripts\python.exe -m ruff format --check app\mcp.py app\mcp_tools.py tests\test_api_mcp.py tests\test_docs_public_urls.py-> 4 files already formatted.\.venv\Scripts\python.exe -m mypy app\mcp.py app\mcp_tools.py-> success.\.venv\Scripts\python.exe scripts\docs_smoke.py-> docs smoke okgit diff --check origin/main...HEAD-> cleangit merge-tree --write-tree origin/main HEAD-> clean treede3fc5c4bd73b62ff49fee9ca013f9dfcb3cf65eScope safety
No wallet registration, wallet transfer signing, ledger mutation, bounty payout, treasury mutation, admin-token behavior, private data, credentials, secrets, exchange, bridge, cash-out, or MRWK price behavior changed.
Summary by CodeRabbit
New Features
get_bountytool now acceptsbounty_idas an alternative parameter for bounty retrieval, enabling more flexible lookup options.Documentation
get_bountybefore preparing evidence submissions.bounty_idparameter usage alongside existing lookup methods.