Share bounty board row rendering#924
Conversation
📝 WalkthroughWalkthroughThe PR extracts Markdown table row formatting logic for bounties into a centralized ChangesBounty table row formatting
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
aunysillyme
left a comment
There was a problem hiding this comment.
Reviewed PR #924 current head 0613b655dda0cb38bbf0b2f080135409a5fc9df6 as a non-author.
Refs #838 review bounty.
Evidence checked:
- Inspected
app/github_bounty_board.py. - Verified
_bounty_table_row()extracts the duplicated table-row rendering for claimable and unavailable bounty-board rows. - Confirmed the helper preserves the same issue link, work-lane, reward, effective-slot, and availability-note cells used by both tables.
- Confirmed sorting and availability bucketing remain in
_claimable_table()and_unavailable_table(), so this is a rendering-path cleanup only. - Confirmed no public API shape, bounty lifecycle, GitHub issue update, treasury, payout, ledger, wallet, admin-token, private data, exchange, bridge, cash-out, or MRWK price behavior is changed.
Validation run on this exact head:
uv run --python 3.12 --extra dev python -m pytest tests/test_github_bounty_board.py -q-> 6 passed.uv run --python 3.12 --extra dev ruff check app/github_bounty_board.py tests/test_github_bounty_board.py-> passed.uv run --python 3.12 --extra dev ruff format --check app/github_bounty_board.py tests/test_github_bounty_board.py-> 2 files already formatted.uv run --python 3.12 --extra dev mypy app/github_bounty_board.py-> success.uv run --python 3.12 --extra dev python scripts/docs_smoke.py-> docs smoke ok.git diff --check origin/main...HEAD-> clean.git merge-tree --write-tree origin/main HEAD-> clean tree7da3e4b12dab3b749d188d573150af6230f96430.
GitHub state before review: PR open, mergeable=MERGEABLE, hosted Quality, readiness, docs, and image checks successful, and no human reviews visible on current head. CodeRabbit was still pending when I reviewed, so maintainers should account for any later bot feedback before merge.
Duplicate/scope check: #838 bounty row 109 is open with effective awards remaining; #924 is distinct from #923 and #922 because it touches GitHub bounty-board row rendering, not GitHub issue finalization requests or bounty-attempt duplicate responses.
No blocker found from the checked code, local validation, hosted CI, and mergeability state.
Summary
_bounty_table_row()helper.Bounty fit
github_bounty_boardrow-rendering scope; no same-scope open PR found.Scope safety
Validation
uv run --python 3.12 --extra dev python -m pytest tests/test_github_bounty_board.py -q-> 6 passeduv run --python 3.12 --extra dev ruff check app/github_bounty_board.py tests/test_github_bounty_board.py-> passeduv run --python 3.12 --extra dev mypy app/github_bounty_board.py-> successuv run --python 3.12 --extra dev ruff format --check app/github_bounty_board.py tests/test_github_bounty_board.py-> already formatteduv run --python 3.12 --extra dev python scripts/docs_smoke.py-> docs smoke okgit diff --check origin/main...HEAD-> cleangit merge-tree --write-tree origin/main HEAD-> clean merge treeSummary by CodeRabbit