Skip to content

Share bounty board row rendering#924

Merged
ramimbo merged 1 commit into
ramimbo:mainfrom
catcherintheroad-hub:codex/share-bounty-board-row-rendering-846
Jun 5, 2026
Merged

Share bounty board row rendering#924
ramimbo merged 1 commit into
ramimbo:mainfrom
catcherintheroad-hub:codex/share-bounty-board-row-rendering-846

Conversation

@catcherintheroad-hub
Copy link
Copy Markdown

@catcherintheroad-hub catcherintheroad-hub commented Jun 5, 2026

Summary

  • Extract the duplicated GitHub bounty board table-row rendering into a private _bounty_table_row() helper.
  • Keep the claimable and unavailable board tables on the same formatting path without changing their output, sorting, or availability rules.

Bounty fit

Scope safety

  • No public API changes.
  • No bounty lifecycle, GitHub issue update, treasury, payout, ledger, wallet, admin-token, private-data, exchange, bridge, cash-out, or MRWK price changes.

Validation

  • uv run --python 3.12 --extra dev python -m pytest tests/test_github_bounty_board.py -q -> 6 passed
  • uv run --python 3.12 --extra dev ruff check app/github_bounty_board.py tests/test_github_bounty_board.py -> passed
  • uv run --python 3.12 --extra dev mypy app/github_bounty_board.py -> success
  • uv run --python 3.12 --extra dev ruff format --check app/github_bounty_board.py tests/test_github_bounty_board.py -> already formatted
  • uv run --python 3.12 --extra dev python scripts/docs_smoke.py -> docs smoke ok
  • git diff --check origin/main...HEAD -> clean
  • git merge-tree --write-tree origin/main HEAD -> clean merge tree

Summary by CodeRabbit

  • Refactor
    • Internal code organization improvements for maintainability with no visible impact to users.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

The PR extracts Markdown table row formatting logic for bounties into a centralized _bounty_table_row(bounty) helper function. The claimable and unavailable bounty table builders are updated to use this helper instead of constructing per-row strings inline, reducing duplication while preserving all board construction behavior.

Changes

Bounty table row formatting

Layer / File(s) Summary
Bounty table row helper extraction and integration
app/github_bounty_board.py
New _bounty_table_row(bounty) helper formats single bounty rows with issue link, work lane, reward, effective slots, and status. Both claimable and unavailable table builders updated to call this helper instead of building rows inline.
🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Share bounty board row rendering' directly names the changed surface and clearly summarizes the main refactoring work.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Mergework Public Artifact Hygiene ✅ Passed PR refactors bounty board row rendering into a helper function with no documentation changes. No investment, price, cash-out, or security claims found.
Bounty Pr Focus ✅ Passed PR changes match scope: single file modified, +14/-22 lines, extracts duplicated row rendering into _bounty_table_row() helper used by both table builders. Public API unchanged.
Description check ✅ Passed PR description comprehensively covers summary, bounty fit, scope safety, and detailed validation evidence against all template requirements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@aunysillyme aunysillyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR #924 current head 0613b655dda0cb38bbf0b2f080135409a5fc9df6 as a non-author.

Refs #838 review bounty.

Evidence checked:

  • Inspected app/github_bounty_board.py.
  • Verified _bounty_table_row() extracts the duplicated table-row rendering for claimable and unavailable bounty-board rows.
  • Confirmed the helper preserves the same issue link, work-lane, reward, effective-slot, and availability-note cells used by both tables.
  • Confirmed sorting and availability bucketing remain in _claimable_table() and _unavailable_table(), so this is a rendering-path cleanup only.
  • Confirmed no public API shape, bounty lifecycle, GitHub issue update, treasury, payout, ledger, wallet, admin-token, private data, exchange, bridge, cash-out, or MRWK price behavior is changed.

Validation run on this exact head:

  • uv run --python 3.12 --extra dev python -m pytest tests/test_github_bounty_board.py -q -> 6 passed.
  • uv run --python 3.12 --extra dev ruff check app/github_bounty_board.py tests/test_github_bounty_board.py -> passed.
  • uv run --python 3.12 --extra dev ruff format --check app/github_bounty_board.py tests/test_github_bounty_board.py -> 2 files already formatted.
  • uv run --python 3.12 --extra dev mypy app/github_bounty_board.py -> success.
  • uv run --python 3.12 --extra dev python scripts/docs_smoke.py -> docs smoke ok.
  • git diff --check origin/main...HEAD -> clean.
  • git merge-tree --write-tree origin/main HEAD -> clean tree 7da3e4b12dab3b749d188d573150af6230f96430.

GitHub state before review: PR open, mergeable=MERGEABLE, hosted Quality, readiness, docs, and image checks successful, and no human reviews visible on current head. CodeRabbit was still pending when I reviewed, so maintainers should account for any later bot feedback before merge.

Duplicate/scope check: #838 bounty row 109 is open with effective awards remaining; #924 is distinct from #923 and #922 because it touches GitHub bounty-board row rendering, not GitHub issue finalization requests or bounty-attempt duplicate responses.

No blocker found from the checked code, local validation, hosted CI, and mergeability state.

@ramimbo ramimbo merged commit 31dfa1f into ramimbo:main Jun 5, 2026
2 checks passed
@ramimbo ramimbo added mrwk:accepted Maintainer accepted for payout mrwk:paid Ledger payment recorded labels Jun 5, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mrwk:accepted Maintainer accepted for payout mrwk:paid Ledger payment recorded

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants