Prevent logout flow being triggert when incorrect credentials are used#1054
Open
indykoning wants to merge 12 commits into4.xfrom
Open
Prevent logout flow being triggert when incorrect credentials are used#1054indykoning wants to merge 12 commits into4.xfrom
indykoning wants to merge 12 commits into4.xfrom
Conversation
Member
|
Maybe we need some tests for this as it's such an edge case but really annoying for customers? |
royduin
reviewed
Nov 18, 2025
| await this.page.waitForTimeout(500) | ||
| await this.page.waitForLoadState('networkidle') | ||
| await expect(page.getByTestId('notifications')).toHaveText( | ||
| 'The account sign-in was incorrect or your account is disabled temporarily. Please wait and try again later.', |
Member
There was a problem hiding this comment.
Didn't we change this weird Magento message in the past?
Member
|
Member
|
See my previous comments + are those new screenshots useful? |
Member
Author
The screenshots are a forced part of the login function perhaps we should move the screenshots array from the checkoutDefault and checkoutOnepage and move it to the constructor? core/tests/playwright/pages/CheckoutPage.js Line 101 in 3ce373a |
Member
|
Follow up: RAP-1815 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents an incorrect password from clearing your cart during login.
By default when triggering login we do not want to clear carts or redirect to login