[5.x] Replace UsesCallbackRelations with afterQuery#1219
Open
[5.x] Replace UsesCallbackRelations with afterQuery#1219
Conversation
Collaborator
Author
|
Neat, the |
royduin
reviewed
Mar 4, 2026
royduin
previously approved these changes
Mar 4, 2026
Member
|
Seems like all the product prices are gone? |
c6b6ed0 to
d697478
Compare
Collaborator
Author
As it turns out, we can't use non-unique keys for the This affected |
7e6ee8c to
26eba45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: RAP-1811
Since Laravel v12.50.0 we can once again use
afterQueryon a relation without the keys being reset (thanks to a fix made by this weird jade-gg person). This means that we don't need to use theUsesCallbackRelationstrait (along with the custom relations) anymore.This also means I was able to remove one of our TODOs relating to manually keying the
pricesrelation after the fact during indexing.Obviously this pins the minimum Laravel version to
^12.50.