[FEA][Java][JNI] Support multi-input groupby aggregations#22377
Draft
malinjawi wants to merge 1 commit intorapidsai:mainfrom
Draft
[FEA][Java][JNI] Support multi-input groupby aggregations#22377malinjawi wants to merge 1 commit intorapidsai:mainfrom
malinjawi wants to merge 1 commit intorapidsai:mainfrom
Conversation
Author
|
I do not have permission to add RAPIDS repo labels from this fork. Could a maintainer please add the required label-checker labels? Suggested labels: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds role-tagged Java/JNI groupby aggregations that allow a logical
multi-input aggregate to be represented by multiple
Aggregationinstancessharing a correlation id. The JNI groupby path buckets those role-tagged
aggregations, dispatches the underlying libcudf request directly, and places
results back in the requested output slots.
This PR adds the initial
min_byroles:GroupByAggregation.orderingForMinBy(long multiInputId)GroupByAggregation.valueForMinBy(long multiInputId)MultiInputIds.next()for thread-safe id generationmulti_input_aggregationdispatch for paired min-by inputsThis avoids forcing callers to pack multi-input aggregate arguments into a
struct column before groupby and unpack the struct afterward.
closes #22276
Validation
clang-format -ion touched native C++ files.git diff --check rapids/main...HEAD.javac -source 8 -target 8.MultiInputAggregationTest.mvn -B surefire:test -Dtest="ai.rapids.cudf.MultiInputAggregationTest#testMultiInputIdsUniqueness+testMinByAggregationEquality" -DfailIfNoTests=falsein the cuDF Java devcontainer.mvn -B install -DskipTests ...in the cuDF Java devcontainer, including nativecudfjnirebuild ofAggregationJni.cppandTableJni.cpp.Checklist