Fix assertion failures in assert_tpch_result_equal due to float sort ambiguity#22378
Open
Matt711 wants to merge 2 commits intorapidsai:mainfrom
Open
Fix assertion failures in assert_tpch_result_equal due to float sort ambiguity#22378Matt711 wants to merge 2 commits intorapidsai:mainfrom
assert_tpch_result_equal due to float sort ambiguity#22378Matt711 wants to merge 2 commits intorapidsai:mainfrom
Conversation
Contributor
|
So my original thinking here was that sorting on the float columns should be unnecessary. Suppose you have a sequence of Assuming
we'd correctly implement that logic. It would pass as long as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When comparing results, sorting by non-float columns alone can leave rows with equal non-float keys in an arbitrary order, causing assert_frame_equal to fail on valid results. This PR retries the comparison using float columns as a secondary sort key before raising a validation error.
Checklist