Deprecate the multi-patterns cudf::strings::replace_re API#22380
Open
davidwendt wants to merge 1 commit intorapidsai:mainfrom
Open
Deprecate the multi-patterns cudf::strings::replace_re API#22380davidwendt wants to merge 1 commit intorapidsai:mainfrom
davidwendt wants to merge 1 commit intorapidsai:mainfrom
Conversation
davidwendt
added
bug
davidwendt
added
libcudf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecates the
cudf::strings::replace_refunction that accepts multiple regex patterns and replacements. This API does not follow the other regex API which all accept aregex_programparameter and has become difficult to maintain. This function pattern is not support by Pandas and there is no JNI wrapper for it either.After trying to create a libcudf benchmark for this API, it was found the function crashes if called with more than a few dozen rows even with only 2 patterns. The crash is due to a bug in the code which has never been reported (the bug was introduced 4 years ago according to git). Therefore, I have complete confidence that this API has never been used and can be removed in a future release.
The gtests have also been removed to prevent deprecation warnings.
This PR also includes a fix for the bug for completeness.
Checklist