Rename build/probe to right/left in hash_join and distinct_hash_join#22382
Open
PointKernel wants to merge 3 commits intorapidsai:mainfrom
Open
Rename build/probe to right/left in hash_join and distinct_hash_join#22382PointKernel wants to merge 3 commits intorapidsai:mainfrom
PointKernel wants to merge 3 commits intorapidsai:mainfrom
Conversation
PointKernel
added
libcudf
3 tasks
PointKernel
force-pushed
the
hash-join-rename-left-right
branch
from
7ff585b to
048ea39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There have been prior discussions about unifying the join interfaces to avoid, or at least reduce, the mixed use of probe/build and left/right terminology, which can be confusing.
This is the first PR in a series that renames join operations to replace the probe/build terminology with left/right. The probe/build roles are not deterministic and can vary depending on the algorithm, whereas left/right provides a consistent and unambiguous reference, minimizing confusion. This PR applies the renaming to
hash_joinanddistinct_hash_join. There are no functional changes, only naming updates.Checklist