Skip to content

check-nightly-ci: update to new version#5433

Merged
jameslamb merged 3 commits intorapidsai:mainfrom
jameslamb:fix/check-nightly-ci
Feb 19, 2026
Merged

check-nightly-ci: update to new version#5433
jameslamb merged 3 commits intorapidsai:mainfrom
jameslamb:fix/check-nightly-ci

Conversation

@jameslamb
Copy link
Copy Markdown
Member

@jameslamb jameslamb commented Feb 17, 2026

Contributes to rapidsai/shared-actions#94

Uses the updated check_nightly_success check from rapidsai/shared-actions#96 . Now that CI check will only ever consider the branch a PR targets, which should prevent issues related to release timing in the future.

Notes for Reviewers

I've intentionally cancelled all other CI here after check-nightly-ci and checks ran, as this only affects check-nightly-ci.

Merging plan:

  1. get this PR approved
  2. get check-nightly-success: limit to 1 branch, other improvements shared-actions#96 approved and merge it
  3. update branch reference to @main here
  4. immediately admin-merge this

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Feb 17, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Feb 17, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Copy Markdown
Member Author

/ok to test

@jameslamb
Copy link
Copy Markdown
Member Author

/ok to test

Comment thread .github/workflows/pr.yaml
repo: ${{ github.repository }}
target-branch: ${{ fromJSON(steps.get-pr-info.outputs.pr-info).base.ref }}
# TODO: remove this when nightly tests are passing again (ref: https://github.com/rapidsai/cugraph/issues/5421)
max-days-without-success: 21
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool this set of PRs found a bug 😁

It looks like, due to the bug being fixed in , check-nightly-ci has been passing on PRs targeting main here for the last few weeks when it really shouldn't have been!!

On this PR:

The oldest run of workflow 'test.yaml' on branch 'main' was 14 days ago (2026-02-03 07:13:23+00:00).
There were 0 successful runs of workflow 'test.yaml' on branch 'main' in the last 7 days.

(build link)

On other recent PRs:

The most recent successful run of the test.yaml workflow on release/26.02 was 2026-02-11 11:13:42+00:00, which is within the last 7 days. View logs:

(build link)

test.yaml hasn't succeeded on main since February 5: https://github.com/rapidsai/cugraph/actions/workflows/test.yaml

But check-nightly-ci was passing because it last passed on release/26.02

The failures look like they're on the RTX Pro 6000 jobs: https://github.com/rapidsai/cugraph/actions/runs/21984468554/job/63515107657

I believe #5422 intentionally only skipped them in PR CI and left them failing for nightlies, but not sure (I didn't think to ask there when I reviewed). The work of fixing those is tracked here: #5421

For now, proposing bumping this up to 21 days. That'd give until February 26 (9 days from now) to fix this.

@jameslamb jameslamb changed the title WIP: check-nightly-ci: update to new version check-nightly-ci: update to new version Feb 17, 2026
@jameslamb jameslamb marked this pull request as ready for review February 17, 2026 19:27
@jameslamb jameslamb requested a review from a team as a code owner February 17, 2026 19:27
@jameslamb jameslamb requested a review from gforsyth February 17, 2026 19:27
Comment thread .github/workflows/pr.yaml Outdated
@jameslamb jameslamb removed the DO NOT MERGE Hold off on merging; see PR for details label Feb 19, 2026
@jameslamb
Copy link
Copy Markdown
Member Author

admin-merging to get things working again, now that rapidsai/shared-actions#96 has been merged

@jameslamb jameslamb merged commit 5ed0897 into rapidsai:main Feb 19, 2026
23 of 37 checks passed
@jameslamb jameslamb deleted the fix/check-nightly-ci branch February 19, 2026 16:51
rapids-bot Bot pushed a commit that referenced this pull request Feb 23, 2026
Follow-up to #5433 

Removes some testing configuration left behind in that PR.

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #5436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants