Use CUDA batch memory copy API wherever possible#954
Open
kingcrimsontianyu wants to merge 9 commits intorapidsai:mainfrom
Open
Use CUDA batch memory copy API wherever possible#954kingcrimsontianyu wants to merge 9 commits intorapidsai:mainfrom
kingcrimsontianyu wants to merge 9 commits intorapidsai:mainfrom
Conversation
kingcrimsontianyu
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 4d1e8c1 |
kingcrimsontianyu
changed the title
vuule
approved these changes
May 6, 2026
Contributor
vuule
left a comment
vuule
left a comment
There was a problem hiding this comment.
Looks good, just one question
Comment on lines
87
to
88
| decltype(cuMemcpyHtoDAsync)* MemcpyHtoDAsync{nullptr}; | ||
| decltype(cuMemcpyDtoHAsync)* MemcpyDtoHAsync{nullptr}; |
Contributor
Author
There was a problem hiding this comment.
They will not be used, but since this is currently part of a public API, I hope they can stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of CUDA batched memory copy for general CPU-GPU copy is recommended by the driver team, as it avoids certain limitations in the traditional memory copy API, such as unexpected device-wide synchronizations. This PR replaces
cuMemcpyHtoDAsyncandcuMemcpyDtoHAsyncwithcuMemcpyBatchAsync.