Conversation
It is no longer supported
Bump PHP7 version and PHPUnit
Use Throwable instead of Exception
# Conflicts: # composer.json
(cherry picked from commit 2a6d3ab)
IoServerTest fails with older versions
…m v1+ futureTick() is missing in older versions
Tweak CI for v0.5
Drop EOLed PHP 7.2 support
|
Thanks a lot for opening this PR. I was able to use your fork as a composer vcs repository and update a symfony application to version 7 successfully thanks to you |
|
Hello, i use plesk, with no problem, but i planed to upgrade symfony to 7.0. With your PR install is ok, but now, no more connection my messagehandler is no more call, and client have It a difference from plesk ? |
|
From plesk : (work with sf 6.4) And i try with doc provided : but my handler is never call ( with breakpoint) with this 2methods WebSocketHandler is MessageHandler implements MessageComponentInterface |
|
WsServer.php replace |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
why is this one not merged yet ? |
| use Symfony\Component\Routing\Matcher\UrlMatcherInterface; | ||
| use Symfony\Component\Routing\Exception\MethodNotAllowedException; | ||
| use Symfony\Component\Routing\Exception\ResourceNotFoundException; | ||
| use GuzzleHttp\Psr7\Query; |
There was a problem hiding this comment.
This namespace removal causes fatal errors because Query::parse and Query::build have not been replaced, in fact it's not even used
| use Symfony\Component\Routing\Exception\MethodNotAllowedException; | ||
| use Symfony\Component\Routing\Exception\ResourceNotFoundException; | ||
| use GuzzleHttp\Psr7\Query; | ||
| use GuzzleHttp\Psr7 as gPsr; |
There was a problem hiding this comment.
| use GuzzleHttp\Psr7 as gPsr; | |
| use GuzzleHttp\Psr7\Query; |
| use Ratchet\RFC6455\Handshake\RequestVerifier; | ||
| use React\EventLoop\LoopInterface; | ||
| use GuzzleHttp\Psr7\Message; | ||
| use GuzzleHttp\Psr7 as gPsr; |
There was a problem hiding this comment.
| use GuzzleHttp\Psr7 as gPsr; | |
| use GuzzleHttp\Psr7\Message; |
Same here
| , "react/socket": "^1.0 || ^0.8 || ^0.7 || ^0.6 || ^0.5 || ^v1.15" | ||
| , "react/event-loop": ">=v1.5.0" |
There was a problem hiding this comment.
| , "react/socket": "^1.0 || ^0.8 || ^0.7 || ^0.6 || ^0.5 || ^v1.15" | |
| , "react/event-loop": ">=v1.5.0" | |
| , "react/socket": "^1.0 || ^0.8 || ^0.7 || ^0.6 || ^0.5" | |
| , "react/event-loop": ">=0.4" |
*Those changes are unnecessary because the previous range already allows those newer versions
| , "react/socket": "^1.0 || ^0.8 || ^0.7 || ^0.6 || ^0.5 || ^v1.15" | ||
| , "react/event-loop": ">=v1.5.0" | ||
| , "guzzlehttp/psr7": "^1.7|^2.0|^2.6" | ||
| , "symfony/http-foundation": "^2.6|^3.0|^4.0|^5.0|^6.0|^v7.0" |
There was a problem hiding this comment.
| , "symfony/http-foundation": "^2.6|^3.0|^4.0|^5.0|^6.0|^v7.0" | |
| , "symfony/http-foundation": "^2.6|^3.0|^4.0|^5.0|^6.0|^7.0" |
|
Hey! Thanks for this pull request 🙏 As part of our cleanup initiative (#1100), we're closing old PRs that have already been resolved. We've recently merged #1098 which implements the same idea, but turned out to be a bit more involved than initially anticipated. If you have further improvements to suggest, feel free to open a new pull request. We appreciate your contributions and welcome any future enhancements. If you want to support Ratchet, please consider sponsoring our work! ❤️ Thanks again for your contribution. |
No description provided.