Adds Route support in App->route()

[emersion]

This PR allows to provide a Route object as $path in order to be able to build more complex endpoints, such as:

$app->route(new Route('/{any}', array(), array('any' => '.*')), $httpServer);

(this redirects all URLs to the controller)

[cboden]

I'm on the fence about this approach. On the plus side it maintains some ideal configuration for the server security. On the minus side it's breaking both the App and Route abstractions.

The RouteCollection has been exposed as a public property $routes on the App class. Is that open enough to fit your more complex endpoints?

[emersion]

The problem is that we have to set properties such as _controller, Origin and call setHost manually. That's not very convenient, do you have another idea?

[saidmoya12]

For security reasons you cannot implement this directy on the bundle but..

1 you can override the class, (extends)

1. You can install a bundle or library for cors domain

You don't must implement that directly on a bundle becouse that is an specific situation

[mikegioia]

Has there been any update on this? I think the only difference between @emersion 's pull request and the suggestion from @cboden is that the PR sort of collects what I'd have to do anyway with the public $routes collection.

The PR is more of a convenience method in accepting a Route object instead of a path string imo. However, what's painful about manually hitting $routes is that I have to emulate all of the decorations Ratchet adds when creating $decorated. I'll end up copying out more code than if I just extended Ratchet\App with my own class :(

[sudoanand]

This is a real requirement and would love to see this feature.

Please have a look at this related PR: #689

[clue]

Looks like this PR was automatically closed when we renamed our master branch to 0.4.x (see #1091) because the fork was already deleted.

If you think this is still relevant, please update your branch to use 0.4.x as the base and open a new PR. Thanks for your contribution, and sorry for the hassle!

[emersion]

I have no plans to continue working on this. If someone else wants to pick this up, please feel free!