Closed
Conversation
WyriHaximus
approved these changes
Nov 15, 2018
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
The fact that this PR adding PHP 7 support is #700 pleases me 👍
samnela
approved these changes
Nov 17, 2018
Contributor
|
PHPUnit 7 is EOL, @cboden are you considering upgrading PHPUnit to version 9, and drop support for older PHP versions? |
Member
|
v0.5 (next version) to keep BC, v0.6 to drop older PHP versions. See #850 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades to PHPUnit 7.
There are a couple tests for sessions that are marked incomplete because of an
ini_setissue.This also drops travis checking for everything but 7.1 and higher as 7.0 and lower are not supported by PHPUnit 7.
It may be good to bump the project to 7.1 and higher anyway as PHP 7.0 is approaching the end of security support in 17 days.
Includes #683 .