Added more options for specific uses cases#121
Open
matherose wants to merge 1 commit into
Open
Conversation
Add support for filtering PGS subtitles by type based on MKVToolNix metadata: - --full-only: Extract only FULL subtitles (regular, non-forced, non-SDH) - --forced-only: Extract only FORCED subtitles (for foreign language text/signs) - --forced-included: Extract FULL and FORCED subtitles together - --sdh-only: Extract only SDH subtitles (for Deaf and Hard of hearing) - --sdh-included: Extract FULL and SDH subtitles together - --all-included: Extract FULL, FORCED and SDH subtitles together Features: - Auto-detection of subtitle types via MKV metadata - FORCED: Detected via forced_track property - SDH: Auto-detected from track names (SDH, CC, Hearing Impaired, etc.) - FULL: Regular subtitles that are neither forced nor SDH - Enhanced file naming with type suffix (e.g., movie.en.forced.srt) - Support for multiple subtitle types per language when using mixed filters - Updated API with SubtitleTypeFilter enum - Comprehensive documentation and examples Resolves issue where --forced-included and --sdh-included options were mutually exclusive, now users can extract all subtitle types with --all-included.
Owner
|
Thanks for the contribution. I'm not giving much attention to my existing opensource python projects lately. This is not a "small change", but a bigger set of changes/features. So, let me give you some feedback:
If you're willing to accept this feedback, we can incorporate these features to pgsrip. |
Owner
|
I have already refactored MkvTrack to include these flags and I'll refactor MediaPath to also have those flags since they are needed for other requested features. Then I'll include the options to include/exclude them when ripping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for filtering PGS subtitles by type based on MKVToolNix metadata:
--full-only[FULL subtitles]--forced-only[FORCED subtitles]--forced-included[FULL + FORCED]--sdh-only[SDH subtitles]--sdh-included[FULL + SDH]--all-included(default) [FULL, FORCED & SDH]