Fix workspace ID calculation in grid layout#87
Closed
Schlafhase wants to merge 2 commits into
Closed
Conversation
Author
|
Update: I just tested the patch and it seems to work fine. It may be problematic when using grid layouts other than 3x3 though so it should probably be a config option. I wasn't sure how to do that though |
stsolovey
pushed a commit
to stsolovey/hyprtasking
that referenced
this pull request
Jan 1, 2026
…compatibility Rewrites build_overview_layout() to query actual workspaces from monitor instead of calculating IDs with formula. This fixes workspace ID mismatch when using split-monitor-workspaces or hyprsplit plugins. Changes: - Query workspaces via getWorkspacesCopy() instead of formula calculation - Add virtual workspace IDs for empty grid cells - Remove side effects (rawMonitorFocus, moveWorkspaceToMonitor) - Add .count() guards to init_position(), on_hide(), close_open_lerp(), on_move() Fixes: raybbian#86 Related: raybbian#87
stsolovey
pushed a commit
to stsolovey/hyprtasking
that referenced
this pull request
Jan 1, 2026
…compatibility Rewrites build_overview_layout() to query actual workspaces from monitor instead of calculating IDs with formula. This fixes workspace ID mismatch when using split-monitor-workspaces or hyprsplit plugins. Changes: - Query workspaces via getWorkspacesCopy() instead of formula calculation - Add virtual workspace IDs for empty grid cells - Remove side effects (rawMonitorFocus, moveWorkspaceToMonitor) - Add .count() guards to init_position(), on_hide(), close_open_lerp(), on_move() Fixes: raybbian#86 Related: raybbian#87
|
I ran into the same issue and found that a one-line fix doesn't fully solve it — the formula-based approach breaks in various edge cases with hyprsplit. I've submitted #90 with a rewrite that queries actual workspaces from the monitor via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix issue #86. Not sure if this works though.