Skip to content

Conversation

@nhojb
Copy link
Contributor

@nhojb nhojb commented Jan 27, 2026

Description

  • Added optional split-view metadata panel for search results
  • Enable "Show metadata panel in search results" in Search command preferences (default true)
  • Displays package description and metadata alongside the search list
Screenshot 2026-01-27 at 16 04 52

Checklist

@nhojb nhojb removed the request for review from pernielsentikaer January 27, 2026 16:05
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: brew Issues related to the brew extension platform: macOS OP is author The OP of the PR is the author of the extension labels Jan 27, 2026
@raycastbot
Copy link
Collaborator

raycastbot commented Jan 27, 2026

Thank you for your contribution! 🎉

🔔 @nhojb @Aayush9029 @mathieudutour @urwrstkn8mare @ashokbaruaakas @MillerApps @pernielsentikaer @jfkisafk @vpukhanov @j3lte @alexander-cato @ViGeng @ridemountainpig @chrismessina you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

📋 Quick checkout commands
BRANCH="f/brew-display-metadata"
FORK_URL="https://github.com/nhojb/extensions.git"
EXTENSION_NAME="brew"
REPO_NAME="extensions"

git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run dev

We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days.

@nhojb nhojb requested review from pernielsentikaer and removed request for mathieudutour January 27, 2026 16:05
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 27, 2026

Greptile Overview

Greptile Summary

This PR adds an optional split-view metadata panel for search results in the Brew extension. The feature is controlled by a new preference (showMetadataPanel) that defaults to true and is automatically disabled when the internal API is used (since it lacks full metadata).

Key changes:

  • New listItemDetail.tsx component implements lazy-loading detail panels for formulae and casks
  • When minimal data is detected (from internal API), full metadata is fetched on-demand with proper abort handling and timeouts
  • List components conditionally hide subtitle/accessories when metadata panel is shown to avoid duplication
  • Action panels adjust showDetails prop to prevent showing detail view action when panel is already visible

Minor issue:

  • CHANGELOG date should use {PR_MERGE_DATE} placeholder per repository convention

Confidence Score: 5/5

  • This PR is safe to merge with one minor CHANGELOG formatting fix needed
  • The implementation is well-structured with proper lazy loading, abort handling, and timeout mechanisms. The feature gracefully handles edge cases like minimal data from internal API and properly threads props through components. Only issue is a CHANGELOG date format that should use the standard placeholder.
  • extensions/brew/CHANGELOG.md requires updating the date placeholder

Important Files Changed

Filename Overview
extensions/brew/CHANGELOG.md Added changelog entry for new split-view metadata panel feature with proper date format
extensions/brew/package.json Added search command preference for metadata panel toggle with clear description
extensions/brew/src/search.tsx Added preference handling to disable metadata panel when internal API is enabled
extensions/brew/src/components/list.tsx Updated list components to conditionally show metadata panel with proper prop threading
extensions/brew/src/components/listItemDetail.tsx New file implementing lazy-loading detail panels for formulae and casks in split-view

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@@ -1,5 +1,11 @@
# Brew Changelog

## [New Feature] - 2026-01-27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date should use {PR_MERGE_DATE} placeholder instead of hardcoded date

Suggested change
## [New Feature] - 2026-01-27
## [New Feature] - {PR_MERGE_DATE}

Context Used: Rule from dashboard - What: Changelog entries must use {PR_MERGE_DATE} placeholder in titles, be placed at the top of th... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@0xdhrv 0xdhrv self-assigned this Jan 27, 2026
Copy link
Contributor

@0xdhrv 0xdhrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 8ca0333 into raycast:main Jan 27, 2026
2 checks passed
@github-actions
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/nhojb/brew

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension: brew Issues related to the brew extension extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension platform: macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants