fix(tokens): use existing border.radius.large and motion.easing.linear tokens instead of hardcoded values#3360
Open
starboyvarun wants to merge 1 commit intorazorpay:masterfrom
Conversation
…xisting tokens BottomSheet was using spacing[5] (20px workaround) for 16px border radius instead of the already-present border.radius.large token. ProgressBar's indeterminate animation used a hardcoded 'linear' string instead of motion.easing.linear from the token system.
starboyvarun
requested review from
anuraghazra,
kamleshchandnani,
ravikumar-rajagopalan,
rohankokane-dev,
saurabhdaware,
swapnil-kr1 and
tewarig
as code owners
🦋 Changeset detectedLatest commit: 97fc5f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two components had TODO comments and hardcoded values for tokens that already existed in the design system.
BottomSheet (
BottomSheet.native.tsx,getBottomSheetGrabHandleStyles.ts):theme.spacing[5](20px) as a workaround for a 16px border radius with a// TODO: we do not have 16px radius tokencommenttheme.border.radius.large(= 16px) already existed inpackages/blade/src/tokens/global/border.tsProgressBar (
ProgressBarFilled.web.tsx):BoxWithIndeterminateAnimationused a hardcoded'linear'string for the CSS animation easing with a// TODO: Add this in motion tokenscommenttheme.motion.easing.linearalready existed (makeBezier(0,0,0,0)) in the motion tokensmotionEasingto the styled-component'sPicktype so it can receive the prop, and replaced the hardcoded string withcastWebType(getIn(theme.motion, motionEasing))Changes
packages/blade/src/components/BottomSheet/BottomSheet.native.tsx— replacespacing[5]withborder.radius.largeand remove TODOpackages/blade/src/components/BottomSheet/getBottomSheetGrabHandleStyles.ts— same radius fix for the grab handlepackages/blade/src/components/ProgressBar/ProgressBarFilled.web.tsx— threadmotionEasingthrough the styled-component and read it from the tokenTesting
cubic-bezier(0,0,0,0)≡linear), but now tracks the token