Don't change User-Agent to prevent preflight request.#226
Open
hamano wants to merge 1 commit intorbren:masterfrom
Open
Don't change User-Agent to prevent preflight request.#226hamano wants to merge 1 commit intorbren:masterfrom
hamano wants to merge 1 commit intorbren:masterfrom
Conversation
Owner
|
Hmm. If I remember correctly, when running server-side, we need to add a User-Agent header for a lot of feeds to work. So this could be a breaking change. Does passing in the option |
Author
|
@rbren thanks for the reply. |
Owner
|
OK, I think this might be a better solution (untested pseudocode): let headers = {
'User-Agent': 'rss-parser',
}
if (typeof window !== 'undefined' && window.navigator && window.navigator.userAgent) {
headers['User-Agent'] = window.navigator.userAgent;
}This way we won't create a breaking change for server-side rss-parser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I found a weired issue.
rss-parser does not fetch feed that is hosted github.io with Firefox, but no problem with Chrome.
github.io responds
Access-Control-Allow-Origin: *as expected.The cause was that Firefox was sending a CORS preflight request.
There are several conditions for sending a preflight request, one of which is User-Agent changing.
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#examples_of_access_control_scenarios
I think many people will be bothered by this issue, so
I recommend not to set User-Agent by default.