Open
Conversation
- Add 'subtitle' to the fields.feed array in lib/fields.js - Add subtitle property to TypeScript Output interface in index.d.ts Co-authored-by: openhands <openhands@all-hands.dev>
Owner
Author
|
@OpenHands please add an inline comment about these changes |
|
I'm on it! rbren can track my progress at all-hands.dev |
Added comments to clarify that Atom feeds use <subtitle> for feed description. Co-authored-by: openhands <openhands@all-hands.dev>
|
I've added inline comments explaining the subtitle field changes and pushed them to the PR branch. Summary of ChangesChecklist:
Changes made:
The PR #294 has been updated with these inline comments to clarify that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
subtitlefield to the list of feed fields, enabling the parser to automatically extract the<subtitle>element from RSS feeds.Changes
lib/fields.js: Added'subtitle'to thefields.feedarrayindex.d.ts: Addedsubtitle?: string;to the TypeScriptOutputinterface for proper type definitionsMotivation
The
subtitlefield is a common RSS feed element that provides additional descriptive information about a feed. This change allows users to access this field without needing to configure custom fields.Testing
All existing tests pass (38/38).
@rbren can click here to continue refining the PR