RDKB-63802: Fix CSI collection for MLO clients#1016
Open
bmilcz-comcast wants to merge 1 commit intordkcentral:developfrom
Open
RDKB-63802: Fix CSI collection for MLO clients#1016bmilcz-comcast wants to merge 1 commit intordkcentral:developfrom
bmilcz-comcast wants to merge 1 commit intordkcentral:developfrom
Conversation
Contributor
Author
|
Requires #994 |
bmilcz-comcast
force-pushed
the
csi-mlo-fix
branch
2 times, most recently
from
735ef5f to
9888cba
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix CSI data collection for MLO (multi-link) enabled associated clients by ensuring CSI events are attributed to the correct (MLD) client MAC address.
Changes:
- Added a helper in the controller layer to map an incoming MAC to an associated MLD MAC for MLO clients.
- Updated CSI processing to use the mapped associated MAC when publishing CSI events.
- Updated AP index lookup to treat MLO clients as “connected” only when the association/primary link is identified.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
source/core/wifi_ctrl.c |
Adds MLD association lookup helper and refines get_ap_index_from_clientmac() logic for MLO association-link behavior. |
source/apps/csi/wifi_csi.c |
Uses the new MLD association lookup so CSI events are emitted with the MLD MAC instead of a link MAC. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bmilcz-comcast
force-pushed
the
csi-mlo-fix
branch
3 times, most recently
from
d11a45c to
37c34ee
Compare
Reason for change: Fix CSI data collection for MLO enabled associated clients. Test Procedure: Verify build, enable Levl app, provide client MLD MAC address via proper command, check if data is collected. Risks: None Priority: P2 Signed-off-by: Brayan Milczarek <brayan_milczarek@comcast.com>
bmilcz-comcast
force-pushed
the
csi-mlo-fix
branch
from
30dd89b to
6786c7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fix CSI data collection for MLO enabled associated clients.
Test Procedure: Verify build, enable Levl app, provide client MLD MAC address via proper command, check if data is collected. Risks: None
Priority: P2