RDKBWIFI-386: Channel Scan Report - BSS Load element is wrong#989
Open
Sangeetha-selvaraj18 wants to merge 1 commit intordkcentral:developfrom
Open
RDKBWIFI-386: Channel Scan Report - BSS Load element is wrong#989Sangeetha-selvaraj18 wants to merge 1 commit intordkcentral:developfrom
Sangeetha-selvaraj18 wants to merge 1 commit intordkcentral:developfrom
Conversation
github-actions
bot
added
the
community contribution
Sangeetha-selvaraj18
force-pushed
the
bss-load-element
branch
from
2aa5a54 to
e72a900
Compare
Sangeetha-selvaraj18
force-pushed
the
bss-load-element
branch
from
e72a900 to
7418448
Compare
amarnathhullur
requested changes
Mar 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to correct the EasyMesh Channel Scan Report contents by properly propagating scan metadata (aggregate scan duration / scan type) and by forwarding BSS Load-derived fields (channel utilization and station count) from probe responses into the Channel Scan Result TLV sent to EasyMesh.
Changes:
- Populate
aggregate_scan_durationandscan_typeinto EasyMesh scan results instead of hard-coding them to 0. - Forward neighbor BSS fields (
bss_color,channel_utilization,station_count) into EasyMesh neighbor structures rather than using placeholder constants. - Persist the effective scan
dwell_timeback into monitor args so it can be reused downstream (e.g., as aggregate scan duration).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
source/webconfig/wifi_easymesh_translator.c |
Stops using placeholder values and forwards scan duration/type and neighbor BSS fields into EasyMesh scan results. |
source/stats/wifi_stats_radio_channel.c |
Writes the computed/adjusted dwell_time back into args for downstream consumers. |
source/apps/em/wifi_em.c |
Adds logic to populate BSS Load-related fields and to set scan duration/type for the Channel Scan Report. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sangeetha-selvaraj18
force-pushed
the
bss-load-element
branch
2 times, most recently
from
45b89bd to
6f536a9
Compare
Contributor
amarnathhullur
left a comment
amarnathhullur
left a comment
There was a problem hiding this comment.
Minor changes to be resolved
| neighbor->bss_load_element_present = 0; | ||
| neighbor->bss_color = 0; | ||
| neighbor->bss_color = EM_BSS_COLOR_DEFAULT; | ||
| neighbor->bss_load_element_present = 0; |
Retrieve Channel Utilization and Station Count from the BSS Load element of the Probe Response and populate the corresponding fields. Ensure these values are correctly included in the Channel Scan Result TLV within the Channel Scan Report message for EasyMesh. Signed-off-by: Sangeetha <sangeetha.s1@tataelxsi.co.in>
amarnathhullur
force-pushed
the
bss-load-element
branch
from
6f536a9 to
d791cb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populate the Channel Utilization and Station count fetched from the BSS Load element of Probe response and send it to easymesh.
This is part of the Channel Scan Result TLV of the Channel Scan Report Message.