RDKMVE-1795: Compilation error resolve on Upgrade meta-rdk-halif-headers to Version 4.1.2.#221
Open
RDKMVE-1795: Compilation error resolve on Upgrade meta-rdk-halif-headers to Version 4.1.2.#221
Conversation
…ers to Version 4.1.2. Reason for change: Compilation error resolve on Upgrade meta-rdk-halif-headers to Version 4.1.2. Test Procedure: build and verify. Risks: High. Signed-off-by: sundaramuneeswaran_muthuraj@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a compilation error that occurs when upgrading meta-rdk-halif-headers to version 4.1.2, which introduces two new video frame rate enum values (59 fps and 23 fps). The fix conditionally adds the corresponding entries to the _values and _names arrays in frameRate.cpp, guarded by a preprocessor define dsVIDEO_FRAMERATE_59_AND_23_SUPPORT.
Changes:
- Added conditional (
#ifdef dsVIDEO_FRAMERATE_59_AND_23_SUPPORT) entries for 59 fps and 23 fps frame rates to the_valuesfloat array and_namesstring array.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Compilation error resolve on Upgrade meta-rdk-halif-headers to Version 4.1.2.
Test Procedure: build and verify.
Risks: High.
Signed-off-by: sundaramuneeswaran_muthuraj@comcast.com