RDKEVD-6226: Cello - no-spdif output#226
Open
yeshwanth-nagaswamy wants to merge 1 commit intodevelopfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to be a debugging effort for RDKEVD-6226 (Cello - no-spdif output) that has been submitted as-is, containing only temporary debug instrumentation with no actual fix.
Changes:
- Added temporary "YESH:" debug log statements in the SPDIF audio initialization path
- Changed the global default log level from
ERROR_LEVELtoDEBUG_LEVELand alteredINT_INFOto log atDEBUG_LEVEL - Added a debug trace in
getSupportedTypes()to print audio output port types
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| rpc/srv/dsAudio.c | Added two temporary "YESH:" debug log lines in SPDIF audio init path |
| ds/include/dslogger.h | Changed default log level to DEBUG and altered INT_INFO macro semantics |
| ds/audioOutputPortConfig.cpp | Added a temporary "YESH:" debug log in getSupportedTypes() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dllib = dlopen(RDK_DSHAL_NAME, RTLD_LAZY); | ||
| if (dllib) { | ||
| dsSetAudioLevelFunc = (dsSetAudioLevel_t) dlsym(dllib, "dsSetAudioLevel"); | ||
| INT_DEBUG("YESH: dsSetAudioLevelFunc %d \r\n", dsSetAudioLevelFunc); |
| //SPDIF init | ||
| handle = 0; | ||
| if(dsGetAudioPort(dsAUDIOPORT_TYPE_SPDIF,0,&handle) == dsERR_NONE) { | ||
| INT_DEBUG("YESH: dsGetAudioPort of dsAUDIOPORT_TYPE_SPDIF handle received \r\n"); |
|
|
||
| #ifndef DS_LOG_LEVEL | ||
| #define DS_LOG_LEVEL ERROR_LEVEL | ||
| #define DS_LOG_LEVEL DEBUG_LEVEL |
| #endif | ||
|
|
||
| #define INT_INFO(FORMAT, ...) ds_log(INFO_LEVEL, fileName(__FILE__), __LINE__, __FUNCTION__, FORMAT, ##__VA_ARGS__ ) | ||
| #define INT_INFO(FORMAT, ...) ds_log(DEBUG_LEVEL, fileName(__FILE__), __LINE__, __FUNCTION__, FORMAT, ##__VA_ARGS__ ) |
ds/audioOutputPortConfig.cpp
Outdated
| { | ||
| List<AudioOutputPortType> supportedTypes; | ||
| for (std::vector<AudioOutputPortType>::const_iterator it = _aPortTypes.begin(); it != _aPortTypes.end(); it++) { | ||
| INT_ERROR("YESH: supportedTypes _aPortTypes *it %s enabled %d", *it, it->isEnabled()); |
yeshwanth-nagaswamy
force-pushed
the
feature/RDKEVD-6226-spdif
branch
from
f71f7f1 to
a34a42b
Compare
yeshwanth-nagaswamy
force-pushed
the
feature/RDKEVD-6226-spdif
branch
from
a34a42b to
23bae5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ccp.sys.comcast.net/browse/RDKEVD-6226