RDKB-64152 : Add debug logs of Eth client details retrieved from HAL by suriya-prem · Pull Request #55 · rdkcentral/ethernet-agent

suriya-prem · 2026-03-25T11:50:34Z

RDKB-64152 : Add debug logs of Eth client details from HAL

Reason for change: For debugging purpose
Test Procedure: Change log level to debug for getting newly logs.
Risks: Low
Signed-off-by:Suriyanarayanan_MP@comcast.com

Copilot

Pull request overview

Adds additional debug-level logging around Ethernet client/device details obtained from the HAL, to aid field debugging for RDKB-64152.

Changes:

Add debug dumps of associated Ethernet device details (MAC/port/VLAN/rates/active) in multiple Ethernet logging/telemetry paths.
Add additional debug tracing inside the HAL associated-device monitor thread.
Change some existing Ethernet host log markers from warning-level to debug-level.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`source/TR-181/middle_layer_src/cosa_ethernet_internal.c`	Adds debug dumps of associated devices and changes existing `ETH_MAC_` / `ETH_PHYRATE_` markers to debug.
`source/TR-181/board_sbapi/source-arm/cosa_ethernet_apis_arm.c`	Adds debug dumps of associated devices after retrieving them from HAL.
`source/TR-181/board_sbapi/eth_hal_interface.c`	Adds debug tracing throughout the associated-device monitor thread, including per-device detail logs.
`source/TR-181/board_sbapi/cosa_ethernet_apis.c`	Adds debug dump of device details in the associated-device callback path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-25T11:53:58Z

source/TR-181/board_sbapi/cosa_ethernet_apis.c

+	if (eth_dev != NULL) {
+        CcspTraceDebug(("%s: MAC Address : %02X:%02X:%02X:%02X:%02X:%02X, Port:%d, VLAN ID:%d, TX Rate:%d, RX Rate:%d, Active:%s\n", __FUNCTION__,
+               eth_dev->eth_devMacAddress[0], eth_dev->eth_devMacAddress[1], eth_dev->eth_devMacAddress[2], eth_dev->eth_devMacAddress[3],
+               eth_dev->eth_devMacAddress[4], eth_dev->eth_devMacAddress[5], eth_dev->eth_port, eth_dev->eth_vlanid, eth_dev->eth_devTxRate,
+	           eth_dev->eth_devRxRate, eth_dev->eth_Active ? "TRUE" : "FALSE"));
+	}
+
 	    AnscCopyMemory(Eth_Host.eth_macAddr,eth_dev->eth_devMacAddress,6);
        Eth_Host.eth_Active = eth_dev->eth_Active;
 	    Eth_Host.eth_port = eth_dev->eth_port;		


In CosaDmlEth_AssociatedDevice_callback, the added NULL check is ineffective: eth_dev is dereferenced before the check (e.g., when building mac_id) and it is still dereferenced after the check (AnscCopyMemory / field accesses). If eth_dev can ever be NULL, this will still crash; if it can’t, the check should be removed to avoid misleading readers. Consider adding an early guard at the top (before any dereference) and returning failure when eth_dev == NULL (or keep behavior unchanged and drop the check).

Copilot · 2026-03-25T11:53:58Z

source/TR-181/board_sbapi/eth_hal_interface.c

 			bProcessFurther = FALSE;
 		}

+		CcspTraceDebug(("%s:%d bProcessFurther:%d, ulTotalEthDeviceCount:%ld, isDeleteAllDone:%d\n", 


This debug log uses %ld to print ulTotalEthDeviceCount, which is declared as ULONG (unsigned long) in this function. Using the wrong signed format specifier can produce incorrect output and is undefined behavior on some platforms. Switch to %lu (or cast and use the matching specifier) for ulTotalEthDeviceCount.

Suggested change

CcspTraceDebug(("%s:%d bProcessFurther:%d, ulTotalEthDeviceCount:%ld, isDeleteAllDone:%d\n",

CcspTraceDebug(("%s:%d bProcessFurther:%d, ulTotalEthDeviceCount:%lu, isDeleteAllDone:%d\n",

Copilot · 2026-03-25T11:53:59Z

source/TR-181/middle_layer_src/cosa_ethernet_internal.c

        count_client = ethGetClientsCount(i, total_eth_device, output_struct);
-        CcspTraceWarning(("ETH_MAC_%d_TOTAL_COUNT:%d\n", i, count_client));
+        CcspTraceDebug(("ETH_MAC_%d_TOTAL_COUNT:%d\n", i, count_client));
        if (count_client)


These ETH_MAC_* / ETH_PHYRATE_* logs were changed from CcspTraceWarning to CcspTraceDebug, which reduces default visibility and can break any existing log-scraping/telemetry that depends on warning-level markers. If the goal is to add debug detail, consider keeping the existing warning logs and adding separate debug logs instead of changing the level.

Copilot · 2026-03-25T11:53:59Z

source/TR-181/board_sbapi/eth_hal_interface.c

+					CcspTraceDebug(("%s: MAC Address : %02X:%02X:%02X:%02X:%02X:%02X, Port:%d, VLAN ID:%d, TX Rate:%d, RX Rate:%d, Active:%s\n",
+                                           __FUNCTION__, pstRecvEthDevice[iLoopCount].eth_devMacAddress[0],
+                                           pstRecvEthDevice[iLoopCount].eth_devMacAddress[1], pstRecvEthDevice[iLoopCount].eth_devMacAddress[2],
+                                           pstRecvEthDevice[iLoopCount].eth_devMacAddress[3], pstRecvEthDevice[iLoopCount].eth_devMacAddress[4],
+                                           pstRecvEthDevice[iLoopCount].eth_devMacAddress[5], pstRecvEthDevice[iLoopCount].eth_port,
+                                           pstRecvEthDevice[iLoopCount].eth_vlanid, pstRecvEthDevice[iLoopCount].eth_devTxRate,
+                                           pstRecvEthDevice[iLoopCount].eth_devRxRate, pstRecvEthDevice[iLoopCount].eth_Active ? "TRUE" : "FALSE"));


These new debug logs emit full client MAC addresses (and port/VLAN/rate metadata). Even at debug level, this increases exposure of potentially sensitive identifiers and can generate high-volume PII in logs when enabled. Consider masking/hashing MACs (e.g., only last 3 bytes) or gating this behind a dedicated runtime flag/build option used specifically for debugging.

rdkcmf-jenkins · 2026-03-25T12:07:44Z

source/TR-181/board_sbapi/cosa_ethernet_apis.c

 										mac_id,
 										(eth_dev->eth_Active) ? "Connected" : "Disconnected" ));
-
+	if (eth_dev != NULL) {


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Dereference before null check

Null-checking "eth_dev" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Medium Impact, CWE-476
REVERSE_INULL

source/TR-181/middle_layer_src/cosa_ethernet_internal.c

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

source/TR-181/board_sbapi/cosa_ethernet_apis.c:872

The added if (eth_dev != NULL) only guards the new debug log, but the function still unconditionally dereferences eth_dev immediately afterwards (e.g., in sprintf(...)). Either treat NULL as impossible and remove the check, or if NULL is possible, return an error early to avoid a NULL dereference.

	if (eth_dev != NULL) {
        CcspTraceDebug(("%s: MAC Address : %02X:%02X:%02X:%02X:%02X:%02X, Port:%d, VLAN ID:%d, TX Rate:%d, RX Rate:%d, Active:%s\n", __FUNCTION__,
               eth_dev->eth_devMacAddress[0], eth_dev->eth_devMacAddress[1], eth_dev->eth_devMacAddress[2], eth_dev->eth_devMacAddress[3],
               eth_dev->eth_devMacAddress[4], eth_dev->eth_devMacAddress[5], eth_dev->eth_port, eth_dev->eth_vlanid, eth_dev->eth_devTxRate,
	           eth_dev->eth_devRxRate, eth_dev->eth_Active ? "TRUE" : "FALSE"));
	}
	
    sprintf
    (
        mac_id,
        "%02X:%02X:%02X:%02X:%02X:%02X",
        eth_dev->eth_devMacAddress[0],
        eth_dev->eth_devMacAddress[1],

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-30T09:02:13Z

source/TR-181/middle_layer_src/cosa_ethernet_internal.c

+   	CcspTraceDebug(("%s:total_eth_device      : %lu\n", __FUNCTION__, total_eth_device));
+    for (int iLoopCount = 0; iLoopCount < (int) total_eth_device; iLoopCount++) {
+             CcspTraceDebug(("%s: MAC Address : %02X:%02X:%02X:%02X:%02X:%02X, Port:%d, VLAN ID:%d, TX Rate:%d, RX Rate:%d, Active:%s\n", __FUNCTION__,
+                   output_struct[iLoopCount].eth_devMacAddress[0], output_struct[iLoopCount].eth_devMacAddress[1],
+                   output_struct[iLoopCount].eth_devMacAddress[2], output_struct[iLoopCount].eth_devMacAddress[3],
+                   output_struct[iLoopCount].eth_devMacAddress[4], output_struct[iLoopCount].eth_devMacAddress[5],
+                   output_struct[iLoopCount].eth_port, output_struct[iLoopCount].eth_vlanid, output_struct[iLoopCount].eth_devTxRate,
+                   output_struct[iLoopCount].eth_devRxRate, output_struct[iLoopCount].eth_Active ? "TRUE" : "FALSE"));
+    }
+
+


The new debug loop dereferences output_struct[iLoopCount] without checking output_struct is non-NULL. Previously this function could tolerate output_struct == NULL (helpers guard against it), but this log will crash if HAL ever returns success with a NULL pointer. Add a guard (e.g., if (output_struct && total_eth_device > 0)) around the per-device debug dump or ensure the HAL contract guarantees non-NULL when total_eth_device > 0.

Suggested change

CcspTraceDebug(("%s:total_eth_device : %lu\n", __FUNCTION__, total_eth_device));

for (int iLoopCount = 0; iLoopCount < (int) total_eth_device; iLoopCount++) {

CcspTraceDebug(("%s: MAC Address : %02X:%02X:%02X:%02X:%02X:%02X, Port:%d, VLAN ID:%d, TX Rate:%d, RX Rate:%d, Active:%s\n", __FUNCTION__,

output_struct[iLoopCount].eth_devMacAddress[0], output_struct[iLoopCount].eth_devMacAddress[1],

output_struct[iLoopCount].eth_devMacAddress[2], output_struct[iLoopCount].eth_devMacAddress[3],

output_struct[iLoopCount].eth_devMacAddress[4], output_struct[iLoopCount].eth_devMacAddress[5],

output_struct[iLoopCount].eth_port, output_struct[iLoopCount].eth_vlanid, output_struct[iLoopCount].eth_devTxRate,

output_struct[iLoopCount].eth_devRxRate, output_struct[iLoopCount].eth_Active ? "TRUE" : "FALSE"));

}

if (output_struct && total_eth_device > 0)

{

CcspTraceDebug(("%s:total_eth_device : %lu\n", __FUNCTION__, total_eth_device));

for (int iLoopCount = 0; iLoopCount < (int) total_eth_device; iLoopCount++)

{

CcspTraceDebug(("%s: MAC Address : %02X:%02X:%02X:%02X:%02X:%02X, Port:%d, VLAN ID:%d, TX Rate:%d, RX Rate:%d, Active:%s\n", __FUNCTION__,

output_struct[iLoopCount].eth_devMacAddress[0], output_struct[iLoopCount].eth_devMacAddress[1],

output_struct[iLoopCount].eth_devMacAddress[2], output_struct[iLoopCount].eth_devMacAddress[3],

output_struct[iLoopCount].eth_devMacAddress[4], output_struct[iLoopCount].eth_devMacAddress[5],

output_struct[iLoopCount].eth_port, output_struct[iLoopCount].eth_vlanid, output_struct[iLoopCount].eth_devTxRate,

output_struct[iLoopCount].eth_devRxRate, output_struct[iLoopCount].eth_Active ? "TRUE" : "FALSE"));

}

}

Copilot · 2026-03-30T09:02:13Z

source/TR-181/middle_layer_src/cosa_ethernet_internal.c

+	CcspTraceDebug(("%s:total_eth_device      : %lu\n", __FUNCTION__, total_eth_device));
+    for (int iLoopCount = 0; iLoopCount < (int) total_eth_device; iLoopCount++) {
+             CcspTraceDebug(("%s: MAC Address : %02X:%02X:%02X:%02X:%02X:%02X, Port:%d, VLAN ID:%d, TX Rate:%d, RX Rate:%d, Active:%s\n", __FUNCTION__,
+                   output_struct[iLoopCount].eth_devMacAddress[0], output_struct[iLoopCount].eth_devMacAddress[1],
+                   output_struct[iLoopCount].eth_devMacAddress[2], output_struct[iLoopCount].eth_devMacAddress[3],
+                   output_struct[iLoopCount].eth_devMacAddress[4], output_struct[iLoopCount].eth_devMacAddress[5],
+                   output_struct[iLoopCount].eth_port, output_struct[iLoopCount].eth_vlanid, output_struct[iLoopCount].eth_devTxRate,
+                   output_struct[iLoopCount].eth_devRxRate, output_struct[iLoopCount].eth_Active ? "TRUE" : "FALSE"));
+    }


Same as in Ethernet_Log(): this new debug loop unconditionally dereferences output_struct[iLoopCount]. If CcspHalExtSw_getAssociatedDevice can ever return success with output_struct == NULL, this will crash. Please guard the dump with if (output_struct && total_eth_device > 0) (or otherwise enforce the non-NULL contract).

Copilot · 2026-03-30T09:02:14Z

source/TR-181/board_sbapi/source-arm/cosa_ethernet_apis_arm.c

+    for (int iLoopCount = 0; iLoopCount < (int) total_eth_device; iLoopCount++) {
+         CcspTraceDebug(("%s: MAC Address : %02X:%02X:%02X:%02X:%02X:%02X, Port:%d, VLAN ID:%d, TX Rate:%d, RX Rate:%d, Active:%s\n", __FUNCTION__,
+                   output_struct[iLoopCount].eth_devMacAddress[0], output_struct[iLoopCount].eth_devMacAddress[1],
+                   output_struct[iLoopCount].eth_devMacAddress[2], output_struct[iLoopCount].eth_devMacAddress[3],
+                   output_struct[iLoopCount].eth_devMacAddress[4], output_struct[iLoopCount].eth_devMacAddress[5],
+                   output_struct[iLoopCount].eth_port, output_struct[iLoopCount].eth_vlanid, output_struct[iLoopCount].eth_devTxRate,
+                   output_struct[iLoopCount].eth_devRxRate, output_struct[iLoopCount].eth_Active ? "TRUE" : "FALSE"));


This new debug dump iterates and dereferences output_struct[iLoopCount] without checking output_struct is non-NULL. Prior logic only passed the pointer into helpers that guard against NULL, so this introduces a possible crash if HAL returns success with a NULL array pointer. Add a NULL guard (or enforce the HAL contract) before iterating.

Suggested change

for (int iLoopCount = 0; iLoopCount < (int) total_eth_device; iLoopCount++) {

CcspTraceDebug(("%s: MAC Address : %02X:%02X:%02X:%02X:%02X:%02X, Port:%d, VLAN ID:%d, TX Rate:%d, RX Rate:%d, Active:%s\n", __FUNCTION__,

output_struct[iLoopCount].eth_devMacAddress[0], output_struct[iLoopCount].eth_devMacAddress[1],

output_struct[iLoopCount].eth_devMacAddress[2], output_struct[iLoopCount].eth_devMacAddress[3],

output_struct[iLoopCount].eth_devMacAddress[4], output_struct[iLoopCount].eth_devMacAddress[5],

output_struct[iLoopCount].eth_port, output_struct[iLoopCount].eth_vlanid, output_struct[iLoopCount].eth_devTxRate,

output_struct[iLoopCount].eth_devRxRate, output_struct[iLoopCount].eth_Active ? "TRUE" : "FALSE"));

if (output_struct != NULL)

{

for (int iLoopCount = 0; iLoopCount < (int) total_eth_device; iLoopCount++) {

CcspTraceDebug(("%s: MAC Address : %02X:%02X:%02X:%02X:%02X:%02X, Port:%d, VLAN ID:%d, TX Rate:%d, RX Rate:%d, Active:%s\n", __FUNCTION__,

output_struct[iLoopCount].eth_devMacAddress[0], output_struct[iLoopCount].eth_devMacAddress[1],

output_struct[iLoopCount].eth_devMacAddress[2], output_struct[iLoopCount].eth_devMacAddress[3],

output_struct[iLoopCount].eth_devMacAddress[4], output_struct[iLoopCount].eth_devMacAddress[5],

output_struct[iLoopCount].eth_port, output_struct[iLoopCount].eth_vlanid, output_struct[iLoopCount].eth_devTxRate,

output_struct[iLoopCount].eth_devRxRate, output_struct[iLoopCount].eth_Active ? "TRUE" : "FALSE"));

}

rdkcmf-jenkins · 2026-03-30T09:08:50Z

source/TR-181/board_sbapi/cosa_ethernet_apis.c

+	           eth_dev->eth_devRxRate, eth_dev->eth_Active ? "TRUE" : "FALSE"));
+	}
+
    sprintf


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Dereference after null check

Dereferencing null pointer "eth_dev".

Medium Impact, CWE-476
FORWARD_NULL

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

source/TR-181/middle_layer_src/cosa_ethernet_internal.c

Copilot · 2026-04-01T06:30:10Z

source/TR-181/board_sbapi/eth_hal_interface.c

+{	
+	CcspTraceDebug(("%s:%d Entered to create a thread\n", __FUNCTION__, __LINE__));
    AssociatedDevice_callback = callback_proc;
    pthread_t GetAssociatedDeviceThread;
    pthread_create(&GetAssociatedDeviceThread, NULL, &CcspHalExtSw_AssociatedDeviceMonitorThread, NULL);  


The monitoring thread is created but the pthread_create() return value is not checked, and the thread is neither detached nor joined. Since the thread runs indefinitely, leaving it joinable can leak thread resources and makes failures silent. Consider checking pthread_create()'s return code and detaching the thread (or storing the handle for a later join).

source/TR-181/board_sbapi/cosa_ethernet_apis.c

Copilot · 2026-04-01T06:30:11Z

source/TR-181/board_sbapi/cosa_ethernet_apis.c

 										mac_id,
 										(eth_dev->eth_Active) ? "Connected" : "Disconnected" ));
-
+	


This line contains a stray tab on an otherwise blank line. Please remove trailing whitespace to avoid noise in diffs and potential style/lint failures.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-01T06:42:32Z

source/TR-181/board_sbapi/cosa_ethernet_apis.c

 										mac_id,
 										(eth_dev->eth_Active) ? "Connected" : "Disconnected" ));
-
+	


There is a blank line containing a tab character after the log statement. Trailing whitespace can cause noisy diffs and may fail whitespace/lint checks; please remove the tab so this is a truly empty line.

Suggested change

Copilot · 2026-04-01T06:42:32Z

source/TR-181/board_sbapi/eth_hal_interface.c

+	CcspTraceDebug(("%s:%d Entered to monitor thread\n", __FUNCTION__, __LINE__));
 	//Monitor Associated Devices based on periodical time


The new debug messages use awkward phrasing (e.g., "Entered to monitor thread" / "Entered to create a thread"). Consider rewording for clarity so logs are easier to scan (e.g., "Entered monitor thread" and "Creating monitor thread").

Copilot · 2026-04-01T06:42:32Z

source/TR-181/board_sbapi/eth_hal_interface.c

 void CcspHalExtSw_ethAssociatedDevice_callback_register(CcspHalExtSw_ethAssociatedDevice_callback callback_proc)
-{
+{	
+	CcspTraceDebug(("%s:%d Entered to create a thread\n", __FUNCTION__, __LINE__));


The debug log added in the callback register function uses awkward phrasing ("Entered to create a thread"). Consider rewording for clarity (e.g., "Creating monitor thread").

Suggested change

CcspTraceDebug(("%s:%d Entered to create a thread\n", __FUNCTION__, __LINE__));

CcspTraceDebug(("%s:%d Creating monitor thread\n", __FUNCTION__, __LINE__));

suriya-prem added 27 commits March 12, 2026 13:12

Update eth_hal_interface.c

3226b48

Update eth_hal_interface.c

6462dc3

Update cosa_ethernet_apis.c

7e42461

Update cosa_ethernet_internal.c

adbb281

Update cosa_ethernet_apis_arm.c

03cb067

Update cosa_ethernet_apis_arm.c

1456887

Update eth_hal_interface.c

997ffe7

Update cosa_ethernet_apis.c

282e377

Update cosa_ethernet_internal.c

d1fea70

Update cosa_ethernet_internal.c

8a28fdb

Update cosa_ethernet_apis.c

9b19aba

Update cosa_ethernet_apis_arm.c

50a5ecf

Update cosa_ethernet_apis.c

a018aee

Update eth_hal_interface.c

e93df64

Update cosa_ethernet_apis_arm.c

f5090d6

Update cosa_ethernet_internal.c

041222d

Update cosa_ethernet_internal.c

2cf6e2a

Update cosa_ethernet_internal.c

95bc20d

Update cosa_ethernet_apis_arm.c

224acb9

Update cosa_ethernet_apis.c

cd0e1e0

Update eth_hal_interface.c

93307c1

Update eth_hal_interface.c

0568e18

Update cosa_ethernet_apis_arm.c

7aead07

Update cosa_ethernet_internal.c

b009a8a

Update cosa_ethernet_internal.c

b0767dd

Update cosa_ethernet_apis_arm.c

bfeb29f

Update eth_hal_interface.c

9b46d42

Copilot AI review requested due to automatic review settings March 25, 2026 11:50

suriya-prem requested review from a team as code owners March 25, 2026 11:50

Copilot started reviewing on behalf of suriya-prem March 25, 2026 11:50 View session

suriya-prem changed the title ~~RDKB-64152 : Add debug logs of Eth client details from HAL~~ RDKB-64152 : Add debug logs of Eth client details retrieved from HAL Mar 25, 2026

Copilot AI reviewed Mar 25, 2026

View reviewed changes

rdkcmf-jenkins reviewed Mar 25, 2026

View reviewed changes

snayak002c requested changes Mar 27, 2026

View reviewed changes

source/TR-181/middle_layer_src/cosa_ethernet_internal.c Outdated Show resolved Hide resolved

suriya-prem added 2 commits March 30, 2026 14:21

Update eth_hal_interface.c

37dc0d5

Update cosa_ethernet_apis.c

e73d503

Copilot AI review requested due to automatic review settings March 30, 2026 08:57

Copilot started reviewing on behalf of suriya-prem March 30, 2026 08:57 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

rdkcmf-jenkins reviewed Mar 30, 2026

View reviewed changes

suriya-prem added 3 commits April 1, 2026 11:51

Update cosa_ethernet_internal.c

a18b5ad

Update cosa_ethernet_internal.c

c688a3d

Update cosa_ethernet_apis.c

e42c186

Copilot AI review requested due to automatic review settings April 1, 2026 06:26

Copilot started reviewing on behalf of suriya-prem April 1, 2026 06:27 View session

Update cosa_ethernet_apis_arm.c

a9fb1d0

Copilot AI reviewed Apr 1, 2026

View reviewed changes

Update source/TR-181/middle_layer_src/cosa_ethernet_internal.c

7049139

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 1, 2026 06:38

Update source/TR-181/board_sbapi/cosa_ethernet_apis.c

6c6f6fb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of suriya-prem April 1, 2026 06:39 View session

Update source/TR-181/middle_layer_src/cosa_ethernet_internal.c

baf0106

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Apr 1, 2026

View reviewed changes

	CcspTraceDebug(("%s:%d bProcessFurther:%d, ulTotalEthDeviceCount:%ld, isDeleteAllDone:%d\n",
	CcspTraceDebug(("%s:%d bProcessFurther:%d, ulTotalEthDeviceCount:%lu, isDeleteAllDone:%d\n",

		mac_id,
		(eth_dev->eth_Active) ? "Connected" : "Disconnected" ));

		CcspTraceDebug(("%s:%d Entered to monitor thread\n", __FUNCTION__, __LINE__));
		//Monitor Associated Devices based on periodical time

	CcspTraceDebug(("%s:%d Entered to create a thread\n", __FUNCTION__, __LINE__));
	CcspTraceDebug(("%s:%d Creating monitor thread\n", __FUNCTION__, __LINE__));

Conversation

suriya-prem commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

suriya-prem Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Dereference before null check

Uh oh!

suriya-prem Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Dereference after null check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

rdkcmf-jenkins Mar 25, 2026 •

edited

Loading

rdkcmf-jenkins Mar 30, 2026 •

edited

Loading