ci: Simplify names of executables #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR shortens the names of several CMake-built executables and aligns the CI workflow with those new names.
Changes:
- Rename unit test executable target from
FireboltClientUnitTeststoutAppand component test executable fromFireboltClientComponentTeststoctAppintest/CMakeLists.txt. - Rename demo executable target from
FireboltCoreDemo(viaDEMO_APP) todemoAppindemo/CMakeLists.txt. - Update GitHub Actions CI workflow to use the new unit and component test executable names (
utApp,ctApp) when chmod-ing and invoking tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/CMakeLists.txt | Updates unit and component test executable target names and keeps all CMake usage consistent with the new names. |
| demo/CMakeLists.txt | Renames the demo executable target to demoApp, affecting the installed and built binary name. |
| .github/workflows/ci.yml | Adjusts CI steps to chmod and pass the new test executable names (utApp, ctApp) into the Docker-based test runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomasz-blasz
force-pushed
the
topic/ci-simplify-execs
branch
from
e0e707c to
b15cca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.