Topic/otel check #268
Open
Topic/otel check #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds OpenTelemetry instrumentation to the WiFiManager plugin. The implementation adds distributed tracing capabilities to track API calls through the system.
Changes:
- Added OpenTelemetry initialization in the legacy WiFiManager plugin
- Implemented distributed trace instrumentation for the getConnectedSSID method
- Linked the rdk_otlp library in both plugin and legacy CMake configurations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| plugin/CMakeLists.txt | Added rdk_otlp library linkage to MODULE_IMPL_NAME |
| legacy/LegacyWiFiManagerAPIs.cpp | Added rdk_otlp_instrumentation.h include, initialized OpenTelemetry in Initialize method, and added distributed trace calls to getConnectedSSID |
| legacy/CMakeLists.txt | Added rdk_otlp library linkage to PLUGIN_LEGACY_WIFI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.