-
Notifications
You must be signed in to change notification settings - Fork 10
RDKEMW-12614 : Always Enable WiFi upon Migration #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
updated to enable WiFi when BootType as BOOT_MIGRATION Signed-off-by: Muhammed Rafi C <muhammed_rafi@comcast.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements functionality to always enable WiFi and Ethernet interfaces when the system boots with BOOT_TYPE set to BOOT_MIGRATION, allowing network connectivity during migration scenarios. The changes prevent interface disable markers from blocking network access during migration.
Changes:
- Added systemd unit dependency to ensure proper service ordering
- Implemented migration boot detection and marker file cleanup
- Enhanced logging for interface state changes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| plugin/gnome/systemd/gnome-networkmanager-migration.conf | Added service dependency on NM_Bootstrap.service and simplified ExecStartPre command invocation |
| plugin/gnome/scripts/nm_interface_handler.sh | Added BOOT_TYPE detection to remove interface disable markers during migration boot and enhanced logging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| . /etc/device.properties | ||
|
|
||
| # Get BOOT_TYPE | ||
| BOOT_TYPE=$(grep "BOOT_TYPE" /tmp/bootType | cut -d '=' -f 2) |
Copilot
AI
Jan 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grep command could fail if /tmp/bootType doesn't exist, leaving BOOT_TYPE empty. Consider adding a check for file existence or providing a default value to prevent unexpected behavior when the file is missing.
| BOOT_TYPE=$(grep "BOOT_TYPE" /tmp/bootType | cut -d '=' -f 2) | |
| if [ -f /tmp/bootType ]; then | |
| BOOT_TYPE=$(grep "BOOT_TYPE" /tmp/bootType | cut -d '=' -f 2) | |
| else | |
| BOOT_TYPE="" | |
| fi |
| rm -rf "$NSM_ETH_MARKER" | ||
| rm -rf "$NSM_WIFI_MARKER" |
Copilot
AI
Jan 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using 'rm -rf' on marker files is unnecessary and could be dangerous if the variable is unexpectedly empty or contains an incorrect path. Use 'rm -f' instead since these are regular files, not directories. The '-r' flag is only needed for recursive directory removal.
| rm -rf "$NSM_ETH_MARKER" | |
| rm -rf "$NSM_WIFI_MARKER" | |
| rm -f "$NSM_ETH_MARKER" | |
| rm -f "$NSM_WIFI_MARKER" |
updated to enable WiFi when BootType as BOOT_MIGRATION