RDK-58045 : Addressing big parameter passed by value in rbuscore.c#361
Open
rosemarybennyy wants to merge 2 commits intordkcentral:developfrom
Open
RDK-58045 : Addressing big parameter passed by value in rbuscore.c#361rosemarybennyy wants to merge 2 commits intordkcentral:developfrom
rosemarybennyy wants to merge 2 commits intordkcentral:developfrom
Conversation
rosemarybennyy
force-pushed
the
topic/low-priority-cid-155035
branch
from
05a2b10 to
19e653b
Compare
karuna2git
requested changes
Sep 17, 2025
| } *queued_request_t; | ||
|
|
||
| void queued_request_create(queued_request_t* req, rtMessageHeader hdr, rbusMessage msg, server_object_t obj) | ||
| void queued_request_create(queued_request_t* req, const rtMessageHeader* hdr, rbusMessage msg, server_object_t obj) |
rosemarybennyy
force-pushed
the
topic/low-priority-cid-155035
branch
from
5234b43 to
fef87d9
Compare
Reason for change: If rtMessageHeader is a large struct, passing it by value will copy the entire struct
onto the stack, which can be inefficient and unnecessary if the function does not need to modify
the original struct.
Test Procedure: As per RDK-58045
Risks: Low
rosemarybennyy
force-pushed
the
topic/low-priority-cid-155035
branch
from
fef87d9 to
19c64b1
Compare
rosemarybennyy
force-pushed
the
topic/low-priority-cid-155035
branch
from
514b7ce to
d896a05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Addressing big parameter passed by value in rbuscore.c
Test Procedure: as per RDK-58045
Risks: Low