RDK-52984 : Coverity framework integration for remote debugger#1
RDK-52984 : Coverity framework integration for remote debugger#1Abhinavpv28 wants to merge 25 commits intodevelopfrom
Conversation
Reason for change: Adding coverity run workflow in RDK-E github Test Procedure: Run coverity scan Risks: None Priority: P2 Signed-off-by: Abhinav P V Abhinav_Valappil@comcast.com
| name: Build Remote-debugger component in github rdkcentral | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: ghcr.io/rdkcentral/docker-rdk-ci:latest |
There was a problem hiding this comment.
Please use ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:latest instead
cov_build.sh
Outdated
|
|
||
| cd $ROOT | ||
| #Build rbus | ||
| git clone https://github.com/rdkcentral/rbus |
There was a problem hiding this comment.
With use of ghcr.io/rdkcentral/docker-device-mgt-service-test/native-platform:lates, rbus should be already available as part of the container
cov_build.sh
Outdated
| cmake -Hrbus -Bbuild/rbus -DBUILD_FOR_DESKTOP=ON -DCMAKE_BUILD_TYPE=Debug | ||
| make -C build/rbus && make -C build/rbus install | ||
| #Build wdmp-c | ||
| git clone https://github.com/xmidt-org/wdmp-c.git |
There was a problem hiding this comment.
This seems to be a package needed by more than 1 module. Lets move it to https://github.com/rdkcentral/docker-device-mgt-service-test/tree/develop/native-platform
cov_build.sh
Outdated
| sed -i '/WDMP_ERR_SESSION_IN_PROGRESS/a\ WDMP_ERR_INTERNAL_ERROR,\n WDMP_ERR_DEFAULT_VALUE,' /usr/local/include/wdmp-c/wdmp-c.h | ||
| cd $ROOT | ||
| #Build rdk-logger | ||
| git clone https://github.com/rdkcentral/rdk_logger.git |
There was a problem hiding this comment.
Similarly redundant package .
| ninja -C build | ||
| ninja -C build install | ||
| cd $ROOT | ||
| git clone https://github.com/rdkcentral/iarmmgrs.git |
There was a problem hiding this comment.
We have changes to decouple from Iarm . Why are we still needing this clone here ?
cov_build.sh
Outdated
| autoreconf -i | ||
| autoupdate | ||
| ./configure --prefix=${INSTALL_DIR} | ||
| make remotedebugger_CFLAGS="-I/usr/include/cjson -I/usr/local/include/wdmp-c -I/usr/local/include/rbus -I/usr/WebconfigFramework/include -I/usr/iarmmgrs/rdmmgr/include -I/usr/iarmmgrs/hal/include -I/usr/local/include/trower-base64" remotedebugger_LDFLAGS="-L/usr/local/lib -lsafec -lrdkloggers -lcjson -lrfcapi -lrbus -lmsgpackc -lsecure_wrapper -lwebconfig_framework -ltr181api -L/usr/local/lib/x86_64-linux-gnu -ltrower-base64 -L/usr/lib/x86_64-linux-gnu" |
There was a problem hiding this comment.
The dependent modules are built and installed. We may not need to refer to include files from the source checkout locations
|
|
4 participants
Reason for change: Adding coverity run workflow in github
Test Procedure: Run coverity scan
Risks: None
Priority: P2
Signed-off-by: Abhinav P V Abhinav_Valappil@comcast.com