RDK-60307 [RRD] RDK Coverity Defect Resolution for Device Management

[madhubabutt]

Reason for change: Coverity Fix in RRD
Test Procedure: Build and Verify RRD Functionality
Risks: Low
Priority: P1
Signed-off-by:Tirumala, Madhubabu (Contractor) Madhubabu_Tirumala@comcast.com

[github-actions]

Code Coverage Summary

                               Total:|83.6%   5104|97.6%  1301|    -      0

[Copilot]

Pull request overview

This pull request addresses Coverity defects in the RDK Remote Debugger Device Management code, focusing on fixing memory leaks, buffer overflows, and resource handling issues.

Changes:

• Added NULL checks for memory allocations (malloc, strdup, fread) with proper error handling and resource cleanup
• Fixed buffer overflow vulnerabilities by using correct size parameters in strncpy/strncat operations
• Corrected file pointer closure to only occur when pointers are valid (v_secure_pclose moved inside if blocks)
• Fixed memory management issues with rfcbuf allocations and ownership

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/rrdRunCmdThread.c	Added mutex protection for cacheDataNode initialization; fixed buffer overflow in strncpy/strncat; corrected v_secure_pclose placement to prevent potential crashes
src/rrdJsonParser.c	Added NULL checks for malloc/strdup/fread operations with proper cleanup; fixed rfcbuf memory leaks in error paths; clarified rfcbuf ownership with comment
src/rrdEventProcess.c	Fixed staticstrlen calculation after quote removal; corrected appendstrlen calculation; improved realloc error handling with proper log level

[rdkcmf-jenkins]

Coverity Issue - Resource leak

Variable "staticprofiledata" going out of scope leaks the storage it points to.

High Impact, CWE-404
RESOURCE_LEAK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
src/rrdEventProcess.c:251

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[github-actions]

Code Coverage Summary

                               Total:|83.2%   5126|97.6%  1301|    -      0

[github-actions]

Code Coverage Summary

                               Total:|83.0%   5136|97.6%  1301|    -      0

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

src/rrdInterface.c:348

• dataMsg is freed only in the empty-message branch. In the non-empty case, dataMsg is passed to pushIssueTypesToMsgQueue and never freed anywhere in the current flow, which leaks per event. Either make pushIssueTypesToMsgQueue deep-copy the string so the caller can always free dataMsg, or ensure the consumer frees the message buffer after processing (but keep ownership consistent to avoid double-free).

    strncpy(dataMsg, rbusValue_GetString(value, NULL), len-1);
    dataMsg[len-1]='\0';

    if (dataMsg[0] == '\0' || len <= 0  )
    {
        RDK_LOG(RDK_LOG_DEBUG,LOG_REMDEBUG,"[%s:%d]: Message Received is empty, Exit Processing!!! \n", __FUNCTION__, __LINE__);
        free(dataMsg);
    }
    else
    {
        pushIssueTypesToMsgQueue(dataMsg, EVENT_MSG);
    }

[github-actions]

Code Coverage Summary

                               Total:|83.1%   5132|97.6%  1301|    -      0

[github-actions]

Code Coverage Summary

                               Total:|82.8%   5148|97.6%  1301|    -      0

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

[github-actions]

Code Coverage Summary

                               Total:|82.8%   5150|97.6%  1301|    -      0

[github-actions]

Code Coverage Summary

                               Total:|82.8%   5150|97.6%  1301|    -      0

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/rrdEventProcess.c:123

• processIssueTypeEvent() allocates/receives a heap data_buf* rbuf from the message queue but never deallocates it (nor rbuf->mdata) before returning. This makes the /* coverity[leaked_storage] */ suppressions elsewhere more likely to be masking a real leak. Consider establishing a clear ownership rule (e.g., consumer always calls RRD_data_buff_deAlloc(rbuf) after processing) and avoid freeing mdata/jsonPath in deep callees if the caller is responsible.

                free(cmdMap);
		cmdMap = NULL;
	    }
        }
    }

[github-actions]

Code Coverage Summary

                               Total:|82.8%   5150|97.6%  1301|    -      0

[github-actions]

Code Coverage Summary

                               Total:|82.8%   5150|97.6%  1301|    -      0

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

[github-actions]

Code Coverage Summary

                               Total:|82.8%   5150|97.6%  1301|    -      0

[github-actions]

Code Coverage Summary

                               Total:|82.8%   5150|97.6%  1301|    -      0

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[github-actions]

Code Coverage Summary

                               Total:|83.0%   5148|97.7%  1301|    -      0

[github-actions]

Code Coverage Summary

                               Total:|83.0%   5148|97.7%  1301|    -      0

[github-actions]

Code Coverage Summary

                               Total:|83.0%   5148|97.7%  1301|    -      0

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.