Skip to content

fix: use dynamic future dates in key control tests #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanjin99 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use dynamic future dates in key control tests #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e3266e
fix: use dynamic future dates in key control tests
Mar 6, 2026
9012411
Update test/main/cpp/keyctrl.cpp
seanjin99 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions test/main/cpp/keyctrl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2020-2023 Comcast Cable Communications Management, LLC
* Copyright 2020-2026 Comcast Cable Communications Management, LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -23,6 +23,22 @@
#include "sec_security_utils.h"
#include "sign.h"
#include "test_ctx.h"
#include <ctime>
#include <string>

// Returns an ISO 8601 date string N years from now, e.g. "2036-03-06T00:00:00Z".
// Used for test key validity so tests never expire.
static std::string futureDate(int yearsFromNow) {
time_t now = time(nullptr);
struct tm t;
gmtime_r(&now, &t);
t.tm_year += yearsFromNow;
char buf[32];
snprintf(buf, sizeof(buf), "%04d-%02d-%02dT%02d:%02d:%02dZ",
t.tm_year + 1900, t.tm_mon + 1, t.tm_mday,
t.tm_hour, t.tm_min, t.tm_sec);
return buf;
}

#define BUFFER_SIZE 4096

Expand Down Expand Up @@ -168,7 +184,7 @@ Sec_Result testKeyCtrlKeyOnlyUsage(int version, const char* alg) {
std::string jtype = createJTypeContainer("1WXQ46EYW65SENER", "HS256", g_default_jtype_data.contentKey,
g_default_jtype_data.encryptionKey, "9c621060-3a17-4813-8dcb-2e9187aaa903",
createDefaultRights(SEC_KEYTYPE_AES_128).c_str(), SEC_FALSE, SEC_KEYUSAGE_KEY, "2010-12-09T19:53:06Z",
"2025-12-09T01:02:03Z", g_default_jtype_data.macKey, version, alg);
futureDate(10).c_str(), g_default_jtype_data.macKey, version, alg);

if (jtype.empty()) {
SEC_LOG_ERROR("CreateJTypeContainer failed");
Expand Down Expand Up @@ -214,7 +230,7 @@ Sec_Result testKeyCtrlUnwrapWithKeyUsage(int version, const char* alg, TestKey c
std::string jtype = createJTypeContainer("1WXQ46EYW65SENER", "HS256", contentKey,
g_default_jtype_data.encryptionKey, "9c621060-3a17-4813-8dcb-2e9187aaa903",
createDefaultRights(TestCreds::getKeyType(contentKey)).c_str(), SEC_FALSE, SEC_KEYUSAGE_KEY,
"2010-12-09T19:53:06Z", "2025-12-09T01:02:03Z", g_default_jtype_data.macKey, version, alg);
"2010-12-09T19:53:06Z", futureDate(10).c_str(), g_default_jtype_data.macKey, version, alg);

if (jtype.empty()) {
SEC_LOG_ERROR("CreateJTypeContainer failed");
Expand Down Expand Up @@ -298,7 +314,7 @@ Sec_Result testKeyCtrlUnwrapWithDataUsage(int version, const char* alg) {
jtype = createJTypeContainer("1WXQ46EYW65SENER", "HS256", g_default_jtype_data.contentKey,
g_default_jtype_data.encryptionKey, "9c621060-3a17-4813-8dcb-2e9187aaa903",
createDefaultRights(SEC_KEYTYPE_AES_128).c_str(), SEC_TRUE, SEC_KEYUSAGE_DATA, "2010-12-09T19:53:06Z",
"2025-12-09T01:02:03Z", g_default_jtype_data.macKey, version, alg);
futureDate(10).c_str(), g_default_jtype_data.macKey, version, alg);
if (jtype.empty()) {
SEC_LOG_ERROR("CreateJTypeContainer failed");
return SEC_RESULT_FAILURE;
Expand Down Expand Up @@ -529,7 +545,8 @@ Sec_Result testKeyCtrlExpectedJTypeProperties(int version, const char* alg, Test
TestCtx ctx;
Sec_KeyHandle* keyHandle = nullptr;
SEC_BYTE iv[SEC_AES_BLOCK_SIZE] = {0x01};
const char* notOnOrAfter = "2025-12-09T19:53:06Z";
std::string notOnOrAfterStr = futureDate(10);
const char* notOnOrAfter = notOnOrAfterStr.c_str();
const char* notBefore = "2010-12-09T19:53:06Z";
const char* keyId = "9c621060-3a17-4813-8dcb-2e9187aaa903";
Sec_KeyProperties keyProps;
Expand Down Expand Up @@ -929,7 +946,8 @@ Sec_Result testKeyCtrlExpectedExportedProperties(int version, const char* alg, T
std::string b64rights;
Sec_KeyHandle* keyHandle = nullptr;
SEC_BYTE iv[SEC_AES_BLOCK_SIZE] = {0x01};
const char* notOnOrAfter = "2025-12-09T19:53:06Z";
std::string notOnOrAfterStr = futureDate(10);
const char* notOnOrAfter = notOnOrAfterStr.c_str();
const char* notBefore = "2010-12-09T19:53:06Z";
const char* keyId = "9c621060-3a17-4813-8dcb-2e9187aaa903";
Sec_KeyProperties keyProps;
Expand Down Expand Up @@ -1038,7 +1056,8 @@ Sec_Result testKeyCtrlExportProvisionExport(int version, const char* alg, TestKe
std::string b64rights;
Sec_KeyHandle* keyHandle = nullptr;
SEC_BYTE iv[SEC_AES_BLOCK_SIZE] = {0x01};
const char* notOnOrAfter = "2025-12-09T19:53:06Z";
std::string notOnOrAfterStr = futureDate(10);
const char* notOnOrAfter = notOnOrAfterStr.c_str();
const char* notBefore = "2010-12-09T19:53:06Z";
const char* keyId = "9c621060-3a17-4813-8dcb-2e9187aaa903";
Sec_KeyProperties keyProps;
Expand Down Expand Up @@ -1170,7 +1189,8 @@ Sec_Result testKeyCtrlKeyExportGetSize(int version, const char* alg) {
std::string b64rights;
Sec_KeyHandle* keyHandle = nullptr;
SEC_BYTE iv[SEC_AES_BLOCK_SIZE] = {0x01};
const char* notOnOrAfter = "2025-12-09T19:53:06Z";
std::string notOnOrAfterStr = futureDate(10);
const char* notOnOrAfter = notOnOrAfterStr.c_str();
const char* notBefore = "2010-12-09T19:53:06Z";
const char* keyId = "9c621060-3a17-4813-8dcb-2e9187aaa903";
Sec_KeyProperties keyProps;
Expand Down
Loading