Topic/t2 debug1 by dharshini555 · Pull Request #298 · rdkcentral/telemetry

dharshini555 · 2026-03-24T05:24:59Z

No description provided.

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>

Copilot

Pull request overview

This PR primarily increases log verbosity across the Telemetry 2.0 codebase by promoting many T2Debug logs to T2Info, and it also changes the T2Debug macro to log at INFO level. One functional addition was made to print saved seek-map file contents after writing.

Changes:

Promotes many debug-level log statements to info-level across telemetry components (XConf client, parsers, scheduler, report generation, protocol interfaces, DCA utilities, CCSP interfaces, bulkdata).
Changes T2Debug macro to emit INFO logs.
Adds a post-save seek-map file dump using a popen("cat ...") shell command.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
source/xconf-client/xconfclient.c	Promotes XConf client logs to INFO (including logging full downloaded config).
source/utils/t2MtlsUtils.c	Promotes mTLS utility entry/exit logs to INFO.
source/utils/t2log_wrapper.h	Remaps `T2Debug` macro to INFO.
source/utils/t2common.c	Promotes device-property logging to INFO.
source/utils/persistence.c	Promotes persistence layer logs to INFO (including payload/config logging).
source/test/dcautils/dcautilTest.cpp	Promotes test logging to INFO.
source/telemetry2_0.c	Promotes core daemon init/signal logs to INFO.
source/t2parser/t2parserxconf.c	Promotes XConf parser logs to INFO (including logging full config payload).
source/t2parser/t2parser.c	Promotes report profile parser logs to INFO.
source/scheduler/scheduler.c	Promotes scheduler logs to INFO; minor whitespace change.
source/reportgen/reportgen.c	Promotes report generation logs to INFO.
source/protocol/rbusMethod/rbusmethodinterface.c	Promotes RBUS method interface entry/exit logs to INFO.
source/protocol/http/multicurlinterface.c	Promotes HTTP pool/curl logs to INFO.
source/protocol/http/curlinterface.c	Promotes HTTP send logs to INFO.
source/privacycontrol/rdkservices_privacyutils.c	Promotes privacy stub logs to INFO.
source/dcautil/legacyutils.c	Promotes DCA legacy utility logs to INFO.
source/dcautil/dcautil.c	Promotes logs to INFO and adds `popen("cat ...")` to dump saved seek config; contains unreachable log after return.
source/dcautil/dcaproc.c	Promotes process CPU/memory collection logs to INFO.
source/dcautil/dca.c	Promotes DCA grep/top processing logs to INFO and adds additional INFO logging of marker/seek values.
source/ccspinterface/ccspinterface.c	Promotes CCSP interface logs to INFO.
source/ccspinterface/busInterface.c	Promotes bus-interface logs to INFO.
source/bulkdata/t2markers.c	Promotes marker-component map logs to INFO.
source/bulkdata/t2eventreceiver.c	Promotes event receiver logs to INFO.
source/bulkdata/reportprofiles.c	Promotes report profile manager logs to INFO (including webconfig/msgpack flow).
source/bulkdata/profilexconf.c	Promotes XConf profile lifecycle logs to INFO.
source/bulkdata/profile.c	Promotes report profile lifecycle/reporting logs to INFO.
source/bulkdata/datamodel.c	Promotes datamodel thread/init logs to INFO.

Copilot · 2026-03-24T05:29:39Z

source/utils/t2log_wrapper.h

 #define T2Info(...)                    T2Log(RDK_LOG_INFO, __VA_ARGS__)
 #define T2Warning(...)                 T2Log(RDK_LOG_WARN, __VA_ARGS__)
-#define T2Debug(...)                   T2Log(RDK_LOG_DEBUG, __VA_ARGS__)
+#define T2Debug(...)                   T2Log(RDK_LOG_INFO, __VA_ARGS__)


T2Debug is being remapped to RDK_LOG_INFO, which changes the meaning of the public logging API and can make formerly-debug-only logs appear at INFO in production (increased log volume, harder filtering). Consider keeping T2Debug mapped to RDK_LOG_DEBUG (or gating it behind the existing debug flag/config) and only promoting specific messages to T2Info when they’re actionable at INFO level.

Suggested change

#define T2Debug(...) T2Log(RDK_LOG_INFO, __VA_ARGS__)

#define T2Debug(...) T2Log(RDK_LOG_DEBUG, __VA_ARGS__)

Copilot · 2026-03-24T05:29:39Z

source/dcautil/dcautil.c

+    // Use system call to cat and print the saved file contents
+    int len = strlen(profileName) + strlen(SEEKFOLDER) + 10;
+    char *catCmd = (char *)malloc(len);
+    snprintf(catCmd, len, "cat %s/%s", SEEKFOLDER, profileName);
+    FILE *fp = popen(catCmd, "r");
+    if(fp != NULL)
+    {
+        char buffer[4096];
+        while(fgets(buffer, sizeof(buffer), fp) != NULL)
+        {
+            T2Info("After saveconfigtofile Contents of %s/%s: %s", SEEKFOLDER, profileName, buffer);
+        }
+        pclose(fp);
+    }
+    free(catCmd);
+


This adds a popen("cat ...") command built from profileName and executes it via the shell. If profileName is influenced by remote configuration, this is a command-injection risk; even if not, it’s an unnecessary shell dependency and extra process spawn on embedded devices. Prefer reading the saved file directly (or logging jsonReport before writing), and avoid popen/system here.

Suggested change

// Use system call to cat and print the saved file contents

int len = strlen(profileName) + strlen(SEEKFOLDER) + 10;

char *catCmd = (char *)malloc(len);

snprintf(catCmd, len, "cat %s/%s", SEEKFOLDER, profileName);

FILE *fp = popen(catCmd, "r");

if(fp != NULL)

{

char buffer[4096];

while(fgets(buffer, sizeof(buffer), fp) != NULL)

{

T2Info("After saveconfigtofile Contents of %s/%s: %s", SEEKFOLDER, profileName, buffer);

}

pclose(fp);

}

free(catCmd);

/* Read back and log the saved file contents without using a shell */

char filePath[512];

int pathLen = snprintf(filePath, sizeof(filePath), "%s/%s", SEEKFOLDER, profileName);

if (pathLen < 0 || pathLen >= (int)sizeof(filePath))

{

T2Error("saveSeekConfigtoFile: File path too long for profile '%s'\n", profileName);

}

else

{

FILE *fp = fopen(filePath, "r");

if (fp != NULL)

{

char buffer[4096];

while (fgets(buffer, sizeof(buffer), fp) != NULL)

{

T2Info("After saveconfigtofile Contents of %s: %s", filePath, buffer);

}

fclose(fp);

}

else

{

T2Error("saveSeekConfigtoFile: Failed to open saved file %s for reading\n", filePath);

}

}

/* Cleanup JSON objects on success path */

cJSON_Delete(valArray);

free(jsonReport);

Copilot · 2026-03-24T05:29:40Z

source/dcautil/dcautil.c

    free(data);
    free(seekFile);
    return T2ERROR_SUCCESS;
-    T2Debug("%s --out\n", __FUNCTION__);
+    T2Info("%s --out\n", __FUNCTION__);
 }


The function returns before the final log line, making the --out log unreachable dead code. Move the log before the return, or remove it to avoid misleading traces.

Copilot · 2026-03-24T05:29:40Z

source/xconf-client/xconfclient.c

+                T2Info("Config received = %s\n", configData);



Logging the full configData payload at INFO can leak the entire server-delivered configuration into logs and significantly increase log volume. Consider logging only summary fields (e.g., profile name/hash/size) at INFO and keep the full payload behind DEBUG with truncation/redaction.

Suggested change

T2Info("Config received = %s\n", configData);

/*

* Avoid logging full configuration payload at INFO level to reduce

* log volume and prevent potential leakage of sensitive data.

* Log only the size at INFO, and a truncated snippet at DEBUG.

*/

size_t configDataLen = strlen(configData);

T2Info("Config received (size=%zu bytes)\n", configDataLen);

#ifdef T2_DEBUG_SUPPORT

if (configDataLen > 0)

{

size_t maxLogLen = 256;

size_t snippetLen = (configDataLen < maxLogLen) ? configDataLen : maxLogLen;

char snippetBuf[257];

if (snippetLen >= sizeof(snippetBuf))

{

snippetLen = sizeof(snippetBuf) - 1;

}

memcpy(snippetBuf, configData, snippetLen);

snippetBuf[snippetLen] = '\0';

T2Debug("Config received snippet (first %zu bytes): %s\n", snippetLen, snippetBuf);

}

#endif

Copilot · 2026-03-24T05:29:40Z

source/t2parser/t2parserxconf.c

    T2ERROR ret = T2ERROR_SUCCESS;
    int marker_count = 0;
-    T2Debug("config data = %s\n", configData);
+    T2Info("config data = %s\n", configData);


configData is the raw XConf configuration payload; logging it in full at INFO can expose configuration contents and create very large logs. Consider logging only a summary (size/profile name) at INFO and keep full dumps behind DEBUG with truncation/redaction.

Suggested change

T2Info("config data = %s\n", configData);

size_t config_len = 0;

static const size_t MAX_CONFIG_LOG_BYTES = 512;

if (configData != NULL) {

config_len = strlen(configData);

}

T2Info("config data length = %zu bytes\n", config_len);

#ifdef DEBUG

if (config_len > 0 && configData != NULL) {

size_t bytes_to_log = (config_len > MAX_CONFIG_LOG_BYTES) ? MAX_CONFIG_LOG_BYTES : config_len;

T2Debug("config data (first %zu bytes) = %.*s\n", bytes_to_log, (int)bytes_to_log, configData);

}

#endif

rdkcmf-jenkins · 2026-03-24T05:48:30Z

source/dcautil/dca.c

        return NULL;
    }
-
+    if(strcmp(needle, "PreviousRebootInfo:") == 0 && strcmp(needle, "PreviousRebootReason:") == 0){


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Constant expression result

The "and" condition "strcmp(needle, "PreviousRebootInfo:") == 0 && strcmp(needle, "PreviousRebootReason:") == 0" can never be true because "needle" cannot be equal to two different values at the same time.

Medium Impact, CWE-569
CONSTANT_EXPRESSION_RESULT

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-24T07:08:34Z

source/dcautil/dcautil.c

+    int len = strlen(profileName) + strlen(SEEKFOLDER) + 10;
+    char *catCmd = (char *)malloc(len);
+    snprintf(catCmd, len, "cat %s/%s", SEEKFOLDER, profileName);
+    FILE *fp = popen(catCmd, "r");


catCmd allocation isn’t checked for failure before snprintf, and the popen failure path doesn’t log/handle errors. Please add NULL checks (and keep cleanup consistent) or remove this block if it’s only for local debugging.

Copilot · 2026-03-24T07:08:34Z

source/dcautil/dca.c

+    if(strcmp(needle, "PreviousRebootInfo:") == 0 || strcmp(needle, "PreviousRebootReason:") == 0){
+       T2Info("strnstr: searching in haystack (len=%zu): %.*s\n", len, (int)len, haystack);
+    }


This conditional logging prints the entire haystack buffer at INFO level. That can leak log contents (potentially sensitive) and can generate extremely large logs depending on len, impacting performance/storage. Consider removing this, downgrading to T2Debug, and/or capping/redacting the logged content (e.g., first N bytes with non-printables escaped).

Copilot · 2026-03-24T07:08:35Z

source/xconf-client/xconfclient.c

-                T2Debug("Config received successfully from URL : %s\n", configURL);
-                T2Debug("Config received = %s\n", configData);
+                T2Info("Config received successfully from URL : %s\n", configURL);
+                T2Info("Config received = %s\n", configData);


Logging the full configuration payload (configData) at INFO level can expose sensitive device/config details and can be very large, leading to log flooding. Please avoid logging raw configs at INFO; keep this at DEBUG, log only a hash/size, or redact sensitive fields.

Suggested change

T2Info("Config received = %s\n", configData);

T2Info("Config received, size = %zu bytes\n", strlen(configData));

dharshini555 added 5 commits March 14, 2026 07:20

Add debug logs in dca.c

73f7796

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>

Add the debug print for haystack

ac066d7

Add debug logs for telemetry2_0

43c586d

Add set log demand true in reboot sequence

5fe0aca

Modify islogdemand as true

7b27131

dharshini555 requested a review from a team as a code owner March 24, 2026 05:25

Copilot AI review requested due to automatic review settings March 24, 2026 05:25

Merge branch 'develop' into topic/t2_debug1

02457c7

Copilot started reviewing on behalf of dharshini555 March 24, 2026 05:26 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

Add print for haystack

02b6c62

rdkcmf-jenkins reviewed Mar 24, 2026

View reviewed changes

Update dca.c

44dbe9b

Copilot AI review requested due to automatic review settings March 24, 2026 07:05

Copilot started reviewing on behalf of dharshini555 March 24, 2026 07:05 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

shibu-kv closed this Apr 3, 2026

github-actions bot locked and limited conversation to collaborators Apr 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Topic/t2 debug1#298

Topic/t2 debug1#298
dharshini555 wants to merge 8 commits intodevelopfrom
topic/t2_debug1

dharshini555 commented Mar 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

rdkcmf-jenkins Mar 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	#define T2Debug(...) T2Log(RDK_LOG_INFO, __VA_ARGS__)
	#define T2Debug(...) T2Log(RDK_LOG_DEBUG, __VA_ARGS__)

-    // Use system call to cat and print the saved file contents
-    int len = strlen(profileName) + strlen(SEEKFOLDER) + 10;
-    char *catCmd = (char *)malloc(len);
-    snprintf(catCmd, len, "cat %s/%s", SEEKFOLDER, profileName);
-    FILE *fp = popen(catCmd, "r");
-    if(fp != NULL)
-    {
-        char buffer[4096];
-        while(fgets(buffer, sizeof(buffer), fp) != NULL)
-        {
-            T2Info("After saveconfigtofile Contents of %s/%s: %s", SEEKFOLDER, profileName, buffer);
-        }
-        pclose(fp);
-    }
-    free(catCmd);
+    /* Read back and log the saved file contents without using a shell */
+    char filePath[512];
+    int pathLen = snprintf(filePath, sizeof(filePath), "%s/%s", SEEKFOLDER, profileName);
+    if (pathLen < 0 || pathLen >= (int)sizeof(filePath))
+    {
+        T2Error("saveSeekConfigtoFile: File path too long for profile '%s'\n", profileName);
+    }
+    else
+    {
+        FILE *fp = fopen(filePath, "r");
+        if (fp != NULL)
+        {
+            char buffer[4096];
+            while (fgets(buffer, sizeof(buffer), fp) != NULL)
+            {
+                T2Info("After saveconfigtofile Contents of %s: %s", filePath, buffer);
+            }
+            fclose(fp);
+        }
+        else
+        {
+            T2Error("saveSeekConfigtoFile: Failed to open saved file %s for reading\n", filePath);
+        }
+    }
+    /* Cleanup JSON objects on success path */
+    cJSON_Delete(valArray);
+    free(jsonReport);

-                T2Info("Config received = %s\n", configData);
+                /*
+                 * Avoid logging full configuration payload at INFO level to reduce
+                 * log volume and prevent potential leakage of sensitive data.
+                 * Log only the size at INFO, and a truncated snippet at DEBUG.
+                 */
+                size_t configDataLen = strlen(configData);
+                T2Info("Config received (size=%zu bytes)\n", configDataLen);
+#ifdef T2_DEBUG_SUPPORT
+                if (configDataLen > 0)
+                {
+                    size_t maxLogLen = 256;
+                    size_t snippetLen = (configDataLen < maxLogLen) ? configDataLen : maxLogLen;
+                    char snippetBuf[257];
+                    if (snippetLen >= sizeof(snippetBuf))
+                    {
+                        snippetLen = sizeof(snippetBuf) - 1;
+                    }
+                    memcpy(snippetBuf, configData, snippetLen);
+                    snippetBuf[snippetLen] = '\0';
+                    T2Debug("Config received snippet (first %zu bytes): %s\n", snippetLen, snippetBuf);
+                }
+#endif

-    T2Info("config data = %s\n", configData);
+    size_t config_len = 0;
+    static const size_t MAX_CONFIG_LOG_BYTES = 512;
+    if (configData != NULL) {
+        config_len = strlen(configData);
+    }
+    T2Info("config data length = %zu bytes\n", config_len);
+#ifdef DEBUG
+    if (config_len > 0 && configData != NULL) {
+        size_t bytes_to_log = (config_len > MAX_CONFIG_LOG_BYTES) ? MAX_CONFIG_LOG_BYTES : config_len;
+        T2Debug("config data (first %zu bytes) = %.*s\n", bytes_to_log, (int)bytes_to_log, configData);
+    }
+#endif

	T2Info("Config received = %s\n", configData);
	T2Info("Config received, size = %zu bytes\n", strlen(configData));

Conversation

dharshini555 commented Mar 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Constant expression result

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rdkcmf-jenkins Mar 24, 2026 •

edited

Loading